Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velero: fix version injection #39609

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@cblecker
Copy link
Contributor

commented May 9, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The injected version matters to velero as it uses this version to line up with a published docker image. We were missing the "v", which was causing tag not found errors when deploying the in-cluster component.

@fxcoudert

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thanks @cblecker you rock!

@fxcoudert fxcoudert closed this in 9299907 May 9, 2019

@cblecker cblecker deleted the cblecker:velero-version branch May 9, 2019

lleger added a commit to lleger/homebrew-core that referenced this pull request May 15, 2019

velero: fix version injection
Closes Homebrew#39609.

Signed-off-by: FX Coudert <fxcoudert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.