Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convox 20190509115116 #39800

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@chenrui333
Copy link
Contributor

commented May 13, 2019

I did pay attention to this weird release name :)

@lembacon

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@Homebrew/core Do we want to keep adding HEAD in these version bump PRs?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@lembacon If the user (@chenrui333 in this case) can confirm they've personally 1) tested it and 2) needed it then I'd be 👍 otherwise 👎.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@MikeMcQuaid I think you are referring me?

Yeah, it works.

brew install convox
brew test convox
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@chenrui333 You'd need to brew install --HEAD convox. Do you personally use/need that?

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

I actually test it when I am in the branch, chenrui333:convox-20190509115116, so I dont think I need that --HEAD

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

git checkout convox-20190509115116
brew install convox
brew test convox

@chenrui333 chenrui333 force-pushed the chenrui333:convox-20190509115116 branch from bdf1d10 to f2e9430 May 14, 2019

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

i just removed HEAD line as I did not actually use it.

@fxcoudert fxcoudert closed this in e62dcfa May 14, 2019

lleger added a commit to lleger/homebrew-core that referenced this pull request May 15, 2019

convox 20190509115116
Closes Homebrew#39800.

Signed-off-by: FX Coudert <fxcoudert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.