Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helmfile 0.60.1 #39830

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@chenrui333
Copy link
Contributor

commented May 14, 2019

No description provided.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

relates to #39648

@Kriechi Kriechi referenced this pull request May 15, 2019

Closed

helmfile 0.59.0 #39648

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

01:11:40 cp -pR /private/tmp/d20190514-41890-coiqio/helmfile-0.60.1/. /private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1
01:11:40 chmod -Rf +w /private/tmp/d20190514-41890-coiqio
01:11:40 ==> go build -ldflags -X main.Version=v0.60.1 -o /usr/local/Cellar/helmfile/0.60.1/bin/helmfile -v github.com/roboll/helmfile
01:11:40 tmpl/context_tmpl.go:5:2: cannot find package "github.com/Masterminds/sprig" in any of:
01:11:40 	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/Masterminds/sprig (from $GOROOT)
01:11:40 	/private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1/src/github.com/Masterminds/sprig (from $GOPATH)
01:11:40 state/create.go:10:2: cannot find package "github.com/imdario/mergo" in any of:
01:11:40 	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/imdario/mergo (from $GOROOT)
01:11:40 	/private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1/src/github.com/imdario/mergo (from $GOPATH)
01:11:40 state/state.go:23:2: cannot find package "github.com/tatsushid/go-prettytable" in any of:
01:11:40 	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/tatsushid/go-prettytable (from $GOROOT)
01:11:40 	/private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1/src/github.com/tatsushid/go-prettytable (from $GOPATH)
01:11:40 cmd/cmd.go:8:2: cannot find package "github.com/urfave/cli" in any of:
01:11:40 	/usr/local/Cellar/go/1.12.5/libexec/src/github.com/urfave/cli (from $GOROOT)
01:11:40 	/private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1/src/github.com/urfave/cli (from $GOPATH)
01:11:40 helmexec/exec.go:11:2: cannot find package "go.uber.org/zap" in any of:
01:11:40 	/usr/local/Cellar/go/1.12.5/libexec/src/go.uber.org/zap (from $GOROOT)
01:11:40 	/private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1/src/go.uber.org/zap (from $GOPATH)
01:11:40 helmexec/exec.go:12:2: cannot find package "go.uber.org/zap/zapcore" in any of:
01:11:40 	/usr/local/Cellar/go/1.12.5/libexec/src/go.uber.org/zap/zapcore (from $GOROOT)
01:11:40 	/private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1/src/go.uber.org/zap/zapcore (from $GOPATH)
01:11:40 tmpl/context_funcs.go:5:2: cannot find package "gopkg.in/yaml.v2" in any of:
01:11:40 	/usr/local/Cellar/go/1.12.5/libexec/src/gopkg.in/yaml.v2 (from $GOROOT)
01:11:40 	/private/tmp/helmfile-20190514-41890-1kjl2b2/helmfile-0.60.1/src/gopkg.in/yaml.v2 (from $GOPATH)
01:11:40 
01:11:40 ==> Formula
01:11:40 Path: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/helmfile.rb
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Relates to this commit, roboll/helmfile@8f030d5#diff-f949e2d81c8076ebbf8af38fcbb72c1f, they moved to go modules in 0.55, we need to adjust the formula. :)

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

I will fix the build issue.

@chenrui333 chenrui333 changed the title helmfile 0.60.1 [WIP] helmfile 0.60.1 May 15, 2019

@chenrui333 chenrui333 force-pushed the chenrui333:helmfile-0.60.1 branch from e800854 to 10d4c54 May 16, 2019

@chenrui333 chenrui333 changed the title [WIP] helmfile 0.60.1 helmfile 0.60.1 May 16, 2019

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Issue should be fixed now

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

00:14:54 ==> brew style helmfile
00:14:58 ==> FAILED
00:14:58 == /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/helmfile.rb ==
00:14:58 C: 39: 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
00:14:58 
00:14:58 1 file inspected, 1 offense detected

@chenrui333 chenrui333 force-pushed the chenrui333:helmfile-0.60.1 branch from 10d4c54 to 7064747 May 18, 2019

@@ -34,7 +36,7 @@ def install
- name: test
EOS
system Formula["kubernetes-helm"].opt_bin/"helm", "init", "--client-only"
output = '"stable" has been added to your repositories'
output = ""

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert May 18, 2019

Member

Match with empty string is not a good test at all, since it always passes I think.

This comment has been minimized.

Copy link
@chenrui333

chenrui333 May 18, 2019

Author Contributor

yeah, you are right, I did realize that 😆

This comment has been minimized.

Copy link
@chenrui333

chenrui333 May 18, 2019

Author Contributor

I will fix it.

This comment has been minimized.

Copy link
@chenrui333

chenrui333 May 19, 2019

Author Contributor

It looks like there is no output for this line, shell_output("#{bin}/helmfile -f helmfile.yaml repos")

This comment has been minimized.

Copy link
@zbeekman

zbeekman May 20, 2019

Member

then a new test is needed and we must validate that the new behavior (having no output) is actually valid, and not indicative of a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.