Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] charm-tools 2.5.2 #40496

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@chenrui333
Copy link
Contributor

commented May 30, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

08:35:11     /usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pystate.h:241:15: note: 'curexc_traceback' declared here
08:35:11         PyObject *curexc_traceback;
08:35:11                   ^
08:35:11     15 errors generated.
08:35:11     error: command 'clang' failed with exit status 1
08:35:11   Running setup.py install for PyYAML: finished with status 'error'
08:35:11 Cleaning up...
08:35:11   Removing source in /private/tmp/pip-req-build-08sxavkk
08:35:11 Removed build tracker '/private/tmp/pip-req-tracker-13xvlx3b'
08:35:11 ERROR: Command "/usr/local/Cellar/charm-tools/2.5.1/libexec/bin/python3.7 -u -c 'import setuptools, tokenize;__file__='"'"'/private/tmp/pip-req-build-08sxavkk/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-ismppbdl/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/Cellar/charm-tools/2.5.1/libexec/bin/../include/site/python3.7/PyYAML" failed with error code 1 in /private/tmp/pip-req-build-08sxavkk/
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Running setup.py install for PyYAML: finished with status 'error'

@Moisan

This comment has been minimized.

Copy link
Member

commented May 30, 2019

I tried to pip install charm-tools on Python 3 but its dependencies fail to install. This will probably be hard to make it work here also. This is due to ruamel.yaml<=0.10.23 in this version.

The pypi version is not up to date with the releases on Github, and there is an issue upstream about this.

I think the best course of action would be to use the Github release 2.5.2 instead.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Cool, I can certainly try with a new PR to use 2.5.2. Yeah, I also found out the pypi is not up to date.

@chenrui333 chenrui333 changed the title charm-tools 2.5.1 charm-tools 2.5.2 May 31, 2019

@chenrui333 chenrui333 changed the title charm-tools 2.5.2 [wip] charm-tools 2.5.2 May 31, 2019

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

20:47:02 pip._internal.exceptions.InstallationError: Command "/usr/local/Cellar/charm-tools/2.5.2/libexec/bin/python3.7 -u -c 'import setuptools, tokenize;__file__='"'"'/private/tmp/pip-req-build-uri6qyn3/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-1xgqvv67/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/Cellar/charm-tools/2.5.2/libexec/bin/../include/site/python3.7/PyYAML" failed with error code 1 in /private/tmp/pip-req-build-uri6qyn3/
20:47:02 
20:47:02 ==> Formula
20:47:02 Path: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/charm-tools.rb
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

20:47:02 ERROR: Command "/usr/local/Cellar/charm-tools/2.5.2/libexec/bin/python3.7 -u -c 'import setuptools, tokenize;file='"'"'/private/tmp/pip-req-build-uri6qyn3/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-1xgqvv67/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/Cellar/charm-tools/2.5.2/libexec/bin/../include/site/python3.7/PyYAML" failed with error code 1 in /private/tmp/pip-req-build-uri6qyn3/

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Maybe that is reason why they did not support py3.7 yet. I will switch to use py2

@Moisan

This comment has been minimized.

Copy link
Member

commented May 31, 2019

I think we should stick with Python3 and update all the resources.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

upstream repo only support py3.5 yet, maybe we should test in the upstream repo first with py3.7 support?

@SMillerDev

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

I'd prefer to use python 3 too.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

ok, I will try with python 3.7 then.

@chenrui333 chenrui333 referenced this pull request Jun 2, 2019

Merged

Upgrade to use py3.7 #523

Revert "Switch to use py2"
This reverts commit edeaa71.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.