Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wildfly-as 17.0.0.Final #40850

Closed

Conversation

Projects
None yet
3 participants
@chenrui333
Copy link
Contributor

commented Jun 10, 2019

Created with brew bump-formula-pr.

@zbeekman

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Any chance we could get better tests for this?

@jasontedor

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@zbeekman I think that we can get a little bit better testing here but not much beyond "does this thing even turn on?". Wildfly is an application server, it would require quite a lot of effort to get real functional tests here. Is it enough that we know Wildfly starts and responds to a main request, as I've suggested in #40883? We can come back to this PR after we have reached a decision there?

@zbeekman

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

As I mentioned in my other PR review: The test here should do more than just dump a help or version message to stdout. If it's client/server software checking logs or stdout/stderr during a graceful exception (such as a failure to authenticate, or a failure to connect to a non-existant server at a dummy uri) is acceptable too. Thanks for adding the test.

I'd like to combine these two PRs, if possible, so that we only need to merge one.

@jasontedor

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Superseded by #40883

@jasontedor jasontedor closed this Jun 12, 2019

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.