Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidapi 0.9.0 #41122

Closed
wants to merge 1 commit into from
Closed

hidapi 0.9.0 #41122

wants to merge 1 commit into from

Conversation

z3ntu
Copy link
Contributor

@z3ntu z3ntu commented Jun 19, 2019

hidapi has a new home at libusb - and 0.9.0 has been released

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@fxcoudert
Copy link
Member

It looks more like a fork than a new home. The old page still exists, there is no redirection, and the new page has very little following. Is there an official announcement about the situation?

@z3ntu
Copy link
Contributor Author

z3ntu commented Jun 19, 2019

Yes, it's a fork because @signal11 hasn't been active at all for a while now and hidapi hasn't seen any activity in the original repository since January 2016 resulting in a number of different forks with open (partly very important) patches applied.

Quote from the libusb/hidapi readme:

It was moved to libusb/hidapi on June 4th, 2019, in order to merge important bugfixes and continue development of the library.

See also signal11/hidapi#373

@Youw
Copy link

Youw commented Jul 1, 2019

The old page still exists, there is no redirection

that can be changed only by the original author, and since he's not answering for so long, the only thing we can do is to assume, that he "got hit by a bus"

still, the project needs to be maintained and libusb maintainer(s) kindly agreed to host hidapi's fork for its further development

signal11/hidapi#373 is the most official discussion, we can have now

also, every time, when there is a new open bug/PR/etc. in https://github.com/signal11/hidapi repo, we (new maintainers) giving a comments with links to https://github.com/libusb/hidapi and briefly explain, why a new repository exists; that strategy works so far - new PRs are coming along

@melMass
Copy link

melMass commented Jul 2, 2019

I'm using brew's hidapi but just realized it uses the old signal11 one. What is the status of this pull request?

@fxcoudert fxcoudert added the maintainer feedback Additional maintainers' opinions may be needed label Jul 2, 2019
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and even the authors webdomain stopped responding to requests. I think it might be good to let libusb take over here, though I would like to see a link referencing either this issue or the upstream one in the formula.

The original author is not active anymore and the project was forked to the libusb organization.

See signal11/hidapi#373 and #41122
@z3ntu
Copy link
Contributor Author

z3ntu commented Jul 2, 2019

I've changed the commit message to include the two issues.

@Qbicz
Copy link

Qbicz commented Jul 15, 2019

@fxcoudert @SMillerDev can we merge this?

@fxcoudert fxcoudert added ready to merge PR can be merged once CI is green and removed maintainer feedback Additional maintainers' opinions may be needed labels Jul 16, 2019
@fxcoudert
Copy link
Member

@BrewTestBot test this please

@fxcoudert fxcoudert closed this in 4b8f760 Jul 17, 2019
@z3ntu z3ntu deleted the hidapi branch July 19, 2019 14:03
@lock lock bot added the outdated PR was locked due to age label Jan 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants