Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift-cli: add zsh completions, improve tests, fix HEAD builds #41656

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@cblecker
Copy link
Contributor

commented Jul 6, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • add zsh completions
  • improve tests to ensure clean builds
  • fix HEAD builds as make target is changing
  • remove deprecated oadm symlink
  • copy over metafiles
@fxcoudert

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Thanks @cblecker

@fxcoudert fxcoudert closed this in 7b4804f Jul 7, 2019

@cblecker cblecker deleted the cblecker:oc-4.2 branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.