Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csound 6.13_1 #41758

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@nwhetsell
Copy link
Contributor

commented Jul 9, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

There may be a few issues with the Csound formula added in pull request #41684:

  1. The error described at #41684 (comment) is because of a CMakeLists.txt replacement that’s no longer necessary.

  2. The 6.13 tag in the https://github.com/csound/csound repository was apparently pushed inadvertently. At this time, there is no 6.13 tag, and visiting https://github.com/csound/csound/releases/tag/6.13 results in a 404 error.

  3. Since Csound’s 6.13 tag wasn’t intended to be pushed, the SHA-256 hash of the source code archive may change when 6.13 is actually released.

This pull request addresses the first issue, but I’m really not sure if it’s possible to address the others (other than another formula revision).

@chenrui333
Copy link
Contributor

left a comment

👍

@nwhetsell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

Here’s where this PR stands:

As a result of this, running brew audit --strict csound fails:

csound:
  * stable: sha256 changed without the version also changing; please create an issue upstream to rule out malicious circumstances and to find out why the file changed.
  * 'revision 1' should be removed
Error: 2 problems in 1 formula detected

I haven't opened an issue at https://github.com/csound/csound/issues because the reason why the file changed is known (the earlier release was done inadvertently).

I’m happy to remove revision 1, but I’m honestly not sure whether I should in this case since this PR technically revises the same version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.