now-cli 16.1.2 (new formula)

[JounQin]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[JounQin]

@SMillerDev @fxcoudert Can we merge this PR then?

[JounQin]

Any new review or let's merge it?

[chrmoritz]

@JounQin I don't think your last commit is really necessary, because they are removing the pkg embedding with the next minor (major?) version completely. Then we should be able to just fetch their transpiled files from npm and do the regular normal node formula installation like in: https://gist.github.com/chrmoritz/cf4274d7934e295bd08f4c4e28e9a166#file-now-cli-rb-L11-L18 (using their canary atm, Edit: We still should patch their upgrade command though).

[JounQin]

@JounQin I don't think your last commit is really necessary, because they are removing the pkg embedding with the next minor (major?) version completely. Then we should be able to just fetch their transpiled files from npm and do the regular normal node formula installation like in: https://gist.github.com/chrmoritz/cf4274d7934e295bd08f4c4e28e9a166#file-now-cli-rb-L11-L14 (using their canary atm, Edit: We still should patch their upgrade command though).

You're the genius, I just learned so much from you, thx! I'll reset the last commit after a while.

[SMillerDev]

can you squash all your commits into one now-cli 15.8.0 (new formula) commit?

[JounQin]

@SMillerDev GitHub can automatically do that before merging.

[jonchang]

@SMillerDev GitHub can automatically do that before merging.

Yes, but unfortunately our binary workflow is incompatible with the Github "squash and merge" feature. See https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#following-up. Please squash and rebase this pull request, thanks.

[JounQin]

@jonchang done.

[SMillerDev]

@BrewTestBot test this please

[JounQin]

What's wrong with @BrewTestBot ?

[chenrui333]

I think it just needs a reboot.

[JounQin]

Can we merge this then? It has been a whole month since the PR created. 😂
@jonchang @SMillerDev

[SMillerDev]

Looks good to me

[chrmoritz]

@SMillerDev: Can we get this merged?
@JounQin: now 16.1.2 is available now, so it couldn't hurt if we upgrade to this beforehand

[JounQin]

Done, can we merge this then?...
@SMillerDev @jonchang