Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kyma-cli 1.5.0 (new formula) #44102

Closed

Conversation

@suleymanakbas91
Copy link
Contributor

commented Sep 10, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@alebcay alebcay added the new formula label Sep 10, 2019
Copy link
Member

left a comment

👍

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Thanks @suleymanakbas91 for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Bottle step has some issue, let's have another build.

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@BrewTestBot test this please

Copy link
Member

left a comment

One small tweak still

cd bin_path do
system "dep", "ensure", "-vendor-only"
system "make", "build-darwin"
bin.install "bin/kyma-darwin"

This comment has been minimized.

Copy link
@SMillerDev

SMillerDev Oct 3, 2019

Member

This can have a second parameter specifying the new name that would make the line below redundant.

This comment has been minimized.

Copy link
@suleymanakbas91

suleymanakbas91 Oct 4, 2019

Author Contributor

Done. Thanks for the tip!

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

@suleymanakbas91 Any update on this PR?

@suleymanakbas91

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

@chenrui333 should be ready to go now :)

@SMillerDev

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Thanks @suleymanakbas91 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.