Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtensorflow 2.0.0 #44106

Closed
wants to merge 2 commits into from

Conversation

@bayandin
Copy link
Contributor

commented Sep 10, 2019

This PR bumps libtensorflow to v2.0.0 and add libtensorflow@1 with v1.14.0


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
@BrewTestBot

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

  • New formulae should not have a bottle do block
@bayandin bayandin force-pushed the bayandin:libtensorflow-2.0.0 branch 5 times, most recently from 5a7ad3a to 0ba46b6 Sep 10, 2019
@fxcoudert

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

I've created libtensorflow@1.15

  • It should be libtensorflow@1 (and the alias, libtensorflow@2)
  • Will the libtensorflow 1.x branch be actively maintained, with new releases planned? See our documentation for acceptable versioned formulas: https://docs.brew.sh/Versions
@bayandin

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@fxcoudert thanks for the review! 👍

It should be libtensorflow@1 (and the alias, libtensorflow@2)

Sure, will do.

Will the libtensorflow 1.x branch be actively maintained, with new releases planned? See our documentation for acceptable versioned formulas: https://docs.brew.sh/Versions

According to a release comment for 1.15.0-rc0:

This is the last 1.x release for TensorFlow. We do not expect to update the 1.x branch with features, although we will issue patch releases to fix vulnerabilities for at least one year.

@bayandin bayandin force-pushed the bayandin:libtensorflow-2.0.0 branch from 0ba46b6 to 4e58d69 Sep 12, 2019
@bayandin bayandin force-pushed the bayandin:libtensorflow-2.0.0 branch from 4e58d69 to 9466919 Sep 23, 2019
@bayandin bayandin force-pushed the bayandin:libtensorflow-2.0.0 branch from 9466919 to 0331bcb Oct 1, 2019
@bayandin bayandin changed the title [WIP] libtensorflow 2.0.0 libtensorflow 2.0.0 Oct 1, 2019
@bayandin bayandin force-pushed the bayandin:libtensorflow-2.0.0 branch from 0331bcb to c1fee7e Oct 1, 2019
@bayandin bayandin marked this pull request as ready for review Oct 1, 2019
@bayandin

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@fxcoudert It seems you have cancelled the build, is there any particular reason for this?

@SMillerDev

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Usually it's ci failure/being stuck

@bayandin

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Ah, I see, thanks!

@bayandin

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@BrewTestBot test this please

@bayandin bayandin force-pushed the bayandin:libtensorflow-2.0.0 branch from c1fee7e to b43624d Oct 2, 2019
@bayandin bayandin force-pushed the bayandin:libtensorflow-2.0.0 branch from b43624d to 2e0ea99 Oct 2, 2019
Copy link
Member

left a comment

👍

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Thanks @bayandin for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@chenrui333 chenrui333 closed this in 1a6b7dd Oct 3, 2019
@bayandin bayandin deleted the bayandin:libtensorflow-2.0.0 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.