Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal: 0.31.1 #44735

Closed
wants to merge 3 commits into from

Conversation

@bcardiff
Copy link
Contributor

commented Sep 30, 2019

There is a new patch release of Crystal.
This release allows moving to the upstream patch of an upcoming feature of bdw-gc.

So in order to remove the custom build of gc for Crystal instroduced in #39026, an update to the bdw-gc formula is needed.

The bdw-gc patch was merged in ivmai/bdwgc#277 and it should be released in 8.2.x


brew audit --strict crystal is complaining locally about llvm@8 been an alias, but it's no longer an alias.

Formula/bdw-gc.rb Outdated Show resolved Hide resolved
@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Looks like the build failed due to the full_index thing.

@bcardiff

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Change with updated sha256 pushed @chenrui333

@fxcoudert

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

upstream patch of an upcoming feature of bdw-gc

It still seems like a large patch to backport, and could possibly introduce other issues…

@bcardiff

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

@fxcoudert If you think that the gc patch is large the alternative would be to keep the gc vendored in crystal as before with the updated patch.

I happy to change to whatever you think is best for homebrew ecosystem.

Note that the gc patch is adding a feature without affecting existing ones.

@bcardiff

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

I pushed the change that keeps gc vendored. Let me know if there is something different that it would be preferred.

@bcardiff bcardiff requested a review from chenrui333 Oct 3, 2019
Copy link
Member

left a comment

lgtm

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Thanks @bcardiff for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@chenrui333 chenrui333 closed this in 822e35b Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.