Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glooctl: update version template and command #44773

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@kdorosh
Copy link
Contributor

commented Oct 1, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Context

glooctl is a cli largely built on kubectl used to install and manage Gloo installations. Learn more on our open-source GitHub page or website.

Goal

glooctl has been updated in the likeness of kubectl; we added the glooctl version command (which reports client & server version) which is meant to replace the deprecated glooctl --version command.

This PR updates our tests to use the new glooctl version command so we can safely remove the glooctl --version command (which only reports client version) without breaking our formula.

@kdorosh

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

For more context, glooctl version is preferred over glooctl --version because we want it to match kubectl, which only supports kubectl version.

This also explains the formatting change (we report versions in json now).

We also wanted to remove the "community edition" output from the version output because we consolidated our open-source and enterprise glooctl CLIs into a single open-source CLI; thus this distinction is no longer needed.

Thanks for taking a look, and let me know if there's anything else you need from me!

sha256 "2887e746e434e1ffa1e58b76217bdde6872f3f2b487a628d5d5032d573489e66" => :mojave
sha256 "ca1da47eac784176de1a4bd9713b543e7868385331ff3a4b54a77cd7fcaac393" => :high_sierra
sha256 "a4cfffa96ebb809203e5119ae4bdaed47300e90fb7272236b20d0f186c14e42e" => :sierra
sha256 "d94a15551f69a953edd7ef7efffd5769e1038c371d020c4c7bc0eda8d90433aa" => :catalina

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert Oct 1, 2019

Member

The bottle block should not be modified, it is handled automatically (from the binaries created on our CI) when we merge

This comment has been minimized.

Copy link
@kdorosh

kdorosh Oct 1, 2019

Author Contributor

This is a misleading diff. There is no difference between this part of the file and the contents of https://github.com/Homebrew/homebrew-core/blob/master/Formula/glooctl.rb#L9-L14

edit: this was because our fork wasn't up to date with current master -- fixed

@@ -2,15 +2,15 @@ class Glooctl < Formula
desc "Envoy-Powered API Gateway"
homepage "https://gloo.solo.io"
url "https://github.com/solo-io/gloo.git",
:tag => "v0.19.1",
:revision => "1539067a393f53a0b793106aaa4676f8ff87df99"
:tag => "v0.20.1",

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert Oct 1, 2019

Member

This is not based on the top of master (which already has 0.20.1)

This comment has been minimized.

Copy link
@kdorosh

kdorosh Oct 1, 2019

Author Contributor

Hmm I'll update our fork and then update this PR. This PR would merge into current master as expected though, it's just the diff is a little confusing

This comment has been minimized.

Copy link
@kdorosh

kdorosh Oct 1, 2019

Author Contributor

updated! b00d86b

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert Oct 1, 2019

Member

This PR would merge into current master as expected though

The github UI can do it, but we merge formulas through a command-line (because of the binary bottles) which requires things to apply on top of master.

@kdorosh kdorosh force-pushed the solo-io:update_glooctl_version_template branch from 4858eaa to b00d86b Oct 1, 2019
@kdorosh kdorosh requested a review from fxcoudert Oct 1, 2019
@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Thanks @kdorosh !!

@fxcoudert fxcoudert merged commit 0b627e7 into Homebrew:master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
@kdorosh kdorosh deleted the solo-io:update_glooctl_version_template branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.