chartmuseum 0.9.0 (new formula) #44825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
reviewed
Oct 2, 2019
|
@prabhu43 any update on this PR? |
|
@chenrui333 I fixed the test. Please check now |
prabhu43
force-pushed
the
master
branch
2 times, most recently
from
baffb6c
to
aa2897d
Compare
chenrui333
reviewed
Oct 10, 2019
chenrui333
reviewed
Oct 10, 2019
Signed-off-by: Prabhu Jayakumar <j.prabhu91@gmail.com>
|
@chenrui333 Any update on this PR? |
SMillerDev
reviewed
Oct 30, 2019
| assert_predicate testpath/"output.log", :exist?, "output.log file should exist" | ||
| assert_match "Starting ChartMuseum {\"port\": 33333}", File.read(testpath/"output.log") | ||
|
|
||
| puts "Test success!!!" |
There was a problem hiding this comment.
Please don't put in formulae.
There was a problem hiding this comment.
@SMillerDev I will remove that puts
| assert_match "Starting ChartMuseum {\"port\": 33333}", File.read(testpath/"output.log") | ||
|
|
||
| puts "Test success!!!" | ||
| exec "kill $(lsof -t -i :33333)" |
There was a problem hiding this comment.
This is already done by the ensure block
There was a problem hiding this comment.
@SMillerDev In ensure block, only the parent process is getting killed
| "build", | ||
| "-v", | ||
| "-ldflags", | ||
| "-X main.Version=#{version} -X main.Revision=9382222", |
There was a problem hiding this comment.
Is that revision always correct?
There was a problem hiding this comment.
No, it will change for different versions. I will fix it by using git url to download
|
Closing for now, due to lack of progress |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?