Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conjure-up 2.6.9 #44831

Closed
wants to merge 2 commits into from

Conversation

@kwmonroe
Copy link
Contributor

commented Oct 2, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Bump core conjure-up to match latest upstream release. Also refresh the related resources (using homebrew-pypi-poet) to latest tested revisions.

Bump core conjure-up to match latest upstream release. Also refresh the
related resources to latest tested revisions.
@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Test failure on Catalina build

19:39:30 ==> /usr/local/Cellar/conjure-up/2.6.9/bin/conjure-up openstack-base metal --show-env
19:39:30 Error: conjure-up: failed
19:39:30 An exception occurred within a child process:
19:39:30 Test::Unit::AssertionFailedError: <0> expected but was
19:39:30 .

@kwmonroe

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Hmmm,test and audit are working for me:

$ brew test conjure-up && echo $?
Testing conjure-up
==> /usr/local/Cellar/conjure-up/2.6.9/bin/conjure-up openstack-base metal --show-env
0

$ brew audit --strict conjure-up && echo $?
0

Let's tweak this so the spell path test (the thing we actually care about) isn't hinged on shell output.

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Yeah, it only failed on Catalina build, so we probably get away with it.

cc @fxcoudert @SMillerDev

@kwmonroe

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Yeah, it only failed on Catalina build, so we probably get away with it.

Ah, of course! I glossed over the darwin19 and ruby-2.6.0 refs when inspecting the failure earlier. I don't have a Catalina env available to dig into this. Is it possible to exclude catalina in the formula?

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

Thanks @kwmonroe for your contribution!!

@chenrui333 chenrui333 closed this in 4485d24 Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.