Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcaca: depend on imlib2 #44887

Closed
wants to merge 1 commit into from

Conversation

@kendfinger
Copy link
Contributor

commented Oct 4, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

libcaca is quite redundant as it stands, as in current master, it only supports BMP file formats. Depending on imlib2 allows it to decode a much wider range of formats.

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Thanks @kendfinger for your contribution!

@chenrui333 chenrui333 closed this in 4eb2ab8 Oct 4, 2019
@jazzwang

This comment has been minimized.

Copy link

commented Oct 13, 2019

mplayer depends on libcaca

~$ brew uses libcaca
mplayer                    plowshare                  toilet

Before this change, it does not require x11.

~$ brew deps mplayer
fontconfig
freetype
libcaca
libpng

After this change, it requires x11

~$ brew deps mplayer
fontconfig
freetype
giflib
imlib2
jpeg
libcaca
libpng
libtiff
~$ brew reinstall mplayer
imlib2: XQuartz 2.7.11 (or newer) is required to install this formula. X11Requirement unsatisfied!
You can install with Homebrew Cask:
  brew cask install xquartz
You can download from:
  https://xquartz.macosforge.org
Error: An unsatisfied requirement failed this build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.