Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grin-wallet 2.1.0 (new formula) #45833

Closed
wants to merge 1 commit into from
Closed

grin-wallet 2.1.0 (new formula) #45833

wants to merge 1 commit into from

Conversation

quentinlesceller
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@zachauten zachauten added the new formula PR adds a new formula to Homebrew/homebrew-core label Oct 26, 2019
@SMillerDev
Copy link
Member

We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

  • Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
  • You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

  • If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
  • If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
  • If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
  • Same if the software requires a virtual machine, docker instance, etc. to be running.

@quentinlesceller
Copy link
Contributor Author

Hi @SMillerDev I just addressed this in the latest commit.

Copy link
Contributor

@zachauten zachauten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the branch down to a single commit.

Formula/grin-wallet.rb Outdated Show resolved Hide resolved
@quentinlesceller
Copy link
Contributor Author

@zachauten Thanks. Squashed to a single commit.

Formula/grin-wallet.rb Outdated Show resolved Hide resolved
@zbeekman zbeekman added the almost there PR is nearly ready to merge label Oct 28, 2019
Copy link
Contributor

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree with my suggestion, can you please make the change and squash/fixup the commit? Should be ready to go after that.

@quentinlesceller
Copy link
Contributor Author

Agree with the suggestion. Changed and squashed.

Copy link
Contributor

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is it possible to add --lock to the cargo install command? Does upstream provide a cargo.lock file?

Formula/grin-wallet.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zbeekman zbeekman added ready to merge PR can be merged once CI is green and removed almost there PR is nearly ready to merge labels Oct 29, 2019
@chenrui333
Copy link
Member

Thanks all, merging now!

@quentinlesceller quentinlesceller deleted the grin-wallet branch October 30, 2019 13:48
@lock lock bot added the outdated PR was locked due to age label Jan 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants