Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grin-wallet 2.1.0 (new formula) #45833

Closed

Conversation

@quentinlesceller
Copy link
Contributor

quentinlesceller commented Oct 25, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@SMillerDev

This comment has been minimized.

Copy link
Member

SMillerDev commented Oct 26, 2019

We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

  • Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
  • You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

  • If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
  • If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
  • If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
  • Same if the software requires a virtual machine, docker instance, etc. to be running.
@quentinlesceller

This comment has been minimized.

Copy link
Contributor Author

quentinlesceller commented Oct 26, 2019

Hi @SMillerDev I just addressed this in the latest commit.

Copy link
Member

zachauten left a comment

Please squash the branch down to a single commit.

Formula/grin-wallet.rb Outdated Show resolved Hide resolved
@quentinlesceller quentinlesceller force-pushed the quentinlesceller:grin-wallet branch from 1717e24 to 5716c97 Oct 26, 2019
@quentinlesceller

This comment has been minimized.

Copy link
Contributor Author

quentinlesceller commented Oct 26, 2019

@zachauten Thanks. Squashed to a single commit.

Formula/grin-wallet.rb Outdated Show resolved Hide resolved
Copy link
Member

zbeekman left a comment

If you agree with my suggestion, can you please make the change and squash/fixup the commit? Should be ready to go after that.

@quentinlesceller quentinlesceller force-pushed the quentinlesceller:grin-wallet branch from 5716c97 to 0636a2a Oct 29, 2019
@quentinlesceller

This comment has been minimized.

Copy link
Contributor Author

quentinlesceller commented Oct 29, 2019

Agree with the suggestion. Changed and squashed.

Copy link
Member

zbeekman left a comment

LGTM, but is it possible to add --lock to the cargo install command? Does upstream provide a cargo.lock file?

Formula/grin-wallet.rb Outdated Show resolved Hide resolved
@quentinlesceller quentinlesceller force-pushed the quentinlesceller:grin-wallet branch from 0636a2a to f4ca43e Oct 29, 2019
Copy link
Member

zbeekman left a comment

LGTM

@quentinlesceller quentinlesceller requested a review from zachauten Oct 29, 2019
@chenrui333

This comment has been minimized.

Copy link
Member

chenrui333 commented Oct 30, 2019

Thanks all, merging now!

@quentinlesceller quentinlesceller deleted the quentinlesceller:grin-wallet branch Oct 30, 2019
@samford samford referenced this pull request Oct 31, 2019
61 of 67 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.