Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-build: remove dependency on openssl #46637

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@gfguthrie
Copy link
Contributor

gfguthrie commented Nov 11, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

ruby-build stopped looking for any version of Homebrew openssl in the latest version b/c of various compatibility issues with the breadth of ruby versions that it can install. Let's stop depending on openssl in the formula so the user doesn't get something installed that isn't used.

PR: rbenv/ruby-build#1375

@fxcoudert fxcoudert merged commit 96efc84 into Homebrew:master Nov 11, 2019
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Nov 11, 2019

Thanks @gfguthrie

@gfguthrie gfguthrie deleted the gfguthrie:ruby-build-openssl branch Nov 11, 2019
@mislav

This comment has been minimized.

Copy link
Contributor

mislav commented Nov 13, 2019

Thank you @gfguthrie! 💖

@CamJN CamJN mentioned this pull request Dec 2, 2019
5 of 5 tasks complete
@lock lock bot added the outdated label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.