New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-build 20160913 #4763

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
4 participants
@hsbt
Contributor

hsbt commented Sep 13, 2016

Created with brew bump-formula-pr.

@zmwangx

This comment has been minimized.

Show comment
Hide comment
@zmwangx

zmwangx Sep 13, 2016

Contributor

Thanks, but dupe of #4762.

Contributor

zmwangx commented Sep 13, 2016

Thanks, but dupe of #4762.

@zmwangx zmwangx closed this Sep 13, 2016

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 13, 2016

Contributor

@zmwangx actually @hsbt is upstream in this case, so I shall defer to him ;)

Contributor

ilovezfs commented Sep 13, 2016

@zmwangx actually @hsbt is upstream in this case, so I shall defer to him ;)

@ilovezfs ilovezfs reopened this Sep 13, 2016

@zmwangx

This comment has been minimized.

Show comment
Hide comment
@zmwangx

zmwangx Sep 13, 2016

Contributor

Sure.

Contributor

zmwangx commented Sep 13, 2016

Sure.

@hsbt

This comment has been minimized.

Show comment
Hide comment
@hsbt

hsbt Sep 13, 2016

Contributor

@zmwangx @liboyue Thank you for advice. It's first time used brew bump-formula-pr introduced rbenv/ruby-build#980 for me.

I'm ok to merge #4762 :octocat:

Contributor

hsbt commented Sep 13, 2016

@zmwangx @liboyue Thank you for advice. It's first time used brew bump-formula-pr introduced rbenv/ruby-build#980 for me.

I'm ok to merge #4762 :octocat:

@zmwangx

This comment has been minimized.

Show comment
Hide comment
@zmwangx

zmwangx Sep 13, 2016

Contributor

Don't worry, I've submitted duplicates myself a couple of times in the past.

Contributor

zmwangx commented Sep 13, 2016

Don't worry, I've submitted duplicates myself a couple of times in the past.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 13, 2016

Contributor

@hsbt you can check for duplicates using these

brew tap homebrew/dev-tools
prs(){(brew ruby -e "formula=Formula[\"$1\"] ; GitHub.issues_for_formula(formula.name, :tap => formula.tap).each { |i| puts i[\"$2\"] }")}
prurls(){(prs "$1" "html_url")}
prtitles(){(prs "$1" "title")}

Example:

bash-4.3$ prurls ruby-build
https://github.com/Homebrew/homebrew-core/pull/4763
bash-4.3$ prtitles ruby-build
ruby-build 20160913
bash-4.3$
Contributor

ilovezfs commented Sep 13, 2016

@hsbt you can check for duplicates using these

brew tap homebrew/dev-tools
prs(){(brew ruby -e "formula=Formula[\"$1\"] ; GitHub.issues_for_formula(formula.name, :tap => formula.tap).each { |i| puts i[\"$2\"] }")}
prurls(){(prs "$1" "html_url")}
prtitles(){(prs "$1" "title")}

Example:

bash-4.3$ prurls ruby-build
https://github.com/Homebrew/homebrew-core/pull/4763
bash-4.3$ prtitles ruby-build
ruby-build 20160913
bash-4.3$
@hsbt

This comment has been minimized.

Show comment
Hide comment
@hsbt

hsbt Sep 13, 2016

Contributor

@ilovezfs It's useful! I will setup it.

Contributor

hsbt commented Sep 13, 2016

@ilovezfs It's useful! I will setup it.

@zmwangx zmwangx merged commit 6b44378 into Homebrew:master Sep 13, 2016

1 check passed

default Build finished.
Details
@zmwangx

This comment has been minimized.

Show comment
Hide comment
@zmwangx

zmwangx Sep 13, 2016

Contributor

Merged as 6b44378. Thank you for your contribution to Homebrew!

Contributor

zmwangx commented Sep 13, 2016

Merged as 6b44378. Thank you for your contribution to Homebrew!

@hsbt hsbt deleted the hsbt:ruby-build-20160913 branch Sep 13, 2016

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.