Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgsm: Add test #48451

Merged
merged 1 commit into from Jan 1, 2020
Merged

libgsm: Add test #48451

merged 1 commit into from Jan 1, 2020

Conversation

@adambuckland
Copy link
Contributor

adambuckland commented Jan 1, 2020

Adds a test. We're safe to use gsm_create() as it purely allocates
memory.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Adds a test. We're safe to use gsm_create() as it purely allocates
memory.
Copy link
Member

chenrui333 left a comment

lgtm

@chenrui333

This comment has been minimized.

Copy link
Member

chenrui333 commented Jan 1, 2020

Thanks @adambuckland for improving the formula!!

@fxcoudert fxcoudert merged commit 39aa033 into Homebrew:master Jan 1, 2020
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.