Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensc: add pkcs11 caveats #48487

Merged
merged 1 commit into from Jan 8, 2020
Merged

opensc: add pkcs11 caveats #48487

merged 1 commit into from Jan 8, 2020

Conversation

@liamdawson
Copy link
Contributor

liamdawson commented Jan 2, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

As per #44786, the formula for OpenSC installs the pkcs11 driver in a way that the OpenSSH agent won't accept:

refusing PKCS#11 add of "/usr/local/Cellar/opensc/0.20.0/lib/opensc-pkcs11.so": provider not whitelisted

The OpenSC cask installs the driver in a manner that works. Noting this in the caveats should help for future users, as the only other advice I've seen is to copy or hard-link the library from the OpenSC formula, and that causes issues on formula updates.

The OpenSC formula skips the linking step if the cask is already installed, so formula updates should not cause issues with this method:

==> opensc cask is installed, skipping link.
Copy link
Member

chenrui333 left a comment

lgtm

@SMillerDev

This comment has been minimized.

Copy link
Member

SMillerDev commented Jan 3, 2020

I think hardcoding the commands is a bit much. Could you leave it at suggesting unlink this formula and install the "caskname" cask.

@zbeekman

This comment has been minimized.

Copy link
Member

zbeekman commented Jan 4, 2020

I agree with @SMillerDev, @liamdawson could you please edit the caveat according to his suggestion with simpler language?

Copy link
Member

zbeekman left a comment

Please use simpler, plain instructions in the caveat, no need for step by step commands, as requested by @SMillerDev

Formula/opensc.rb Outdated Show resolved Hide resolved
Formula/opensc.rb Outdated Show resolved Hide resolved
Formula/opensc.rb Outdated Show resolved Hide resolved
Formula/opensc.rb Outdated Show resolved Hide resolved
Formula/opensc.rb Outdated Show resolved Hide resolved
Formula/opensc.rb Outdated Show resolved Hide resolved
@liamdawson

This comment has been minimized.

Copy link
Contributor Author

liamdawson commented Jan 5, 2020

Squashed in the suggested changes.

@SMillerDev SMillerDev requested a review from zbeekman Jan 8, 2020
@bayandin bayandin merged commit b66cf05 into Homebrew:master Jan 8, 2020
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
@liamdawson liamdawson deleted the liamdawson:opensc-caveats branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.