Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdupes 1.14.0 #48520

Closed
wants to merge 3 commits into from
Closed

jdupes 1.14.0 #48520

wants to merge 3 commits into from

Conversation

@jd-a
Copy link
Contributor

jd-a commented Jan 3, 2020

  • version modification as jdupes has been updated to version 1.14.0

  • Have you followed the guidelines for contributing?

  • Have you checked that there aren't other open pull requests for the same formula update/change?

  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?

  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?


- version modification as jdupes has been updated to version 1.14.0
- added a warning to make clear it is not a drop in replacement for fdupes
Copy link
Member

issyl0 left a comment

Thanks for this, @jd-a. A couple of small changes.

Could you please re-word the commit message to be jdupes 1.14.0?

For future version bumps, brew bump-formula-pr exists to make the process easier.

Formula/jdupes.rb Show resolved Hide resolved
Formula/jdupes.rb Outdated Show resolved Hide resolved
@jd-a jd-a changed the title Update jdupes.rb jdupes 1.14.0 Jan 3, 2020
@jd-a

This comment has been minimized.

Copy link
Contributor Author

jd-a commented Jan 3, 2020

Sorry I believe I am really making a mess of it now...

What would be the proper place for a warning I had improperly used the caveat for?

@jd-a jd-a requested a review from issyl0 Jan 3, 2020
@issyl0
issyl0 approved these changes Jan 3, 2020
Copy link
Member

issyl0 left a comment

This version bump is looking good now - thanks for the quick work, @jd-a! 💪

To whichever maintainer pulls the bottles for this (it won't be me as I don't have my Mac handy for a few days): please squash the three commits together and reword to the usual format. Thanks!

@chenrui333 chenrui333 closed this in 64bc508 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.