Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icecast 2.4.4 #48644

Closed
wants to merge 1 commit into from
Closed

icecast 2.4.4 #48644

wants to merge 1 commit into from

Conversation

@alebcay
Copy link
Member

alebcay commented Jan 7, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This picks up from the work started in #38221. In addition to bumping the version:

  • Uses #{var} as the --local-state-dir so that log files end up in /usr/local/var instead of the Cellar (which leads to permission issues)
  • Adds a test do block
@alebcay alebcay force-pushed the alebcay:icecast-2.4.4 branch from 15c8d44 to 07bcc63 Jan 7, 2020
@chenrui333 chenrui333 closed this in 6d68eaa Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.