Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botan: Sync `uses_from_macos` from Homebrew/linuxbrew-core #48781

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 8, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

- Over in Homebrew/linuxbrew-core, we fixed a failing build for this
formula by specifying uses_from_macos "python@2" => :build. I
was going to sync that here, as per usual, but on closer inspection
the code itself looked to happily be in Python 3 syntax.

- I'm not sure I've done this right or if this is our approach to Python
updates, so some eyes from other maintainers would be appreciated
please!

  • We had more dependencies on Linux that are included in macOS, so sync them here.
@issyl0 issyl0 added the python label Jan 8, 2020
@issyl0 issyl0 force-pushed the issyl0:botan-uses-from-macos branch from 8cf51e5 to c898490 Jan 8, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 8, 2020

Ignore the Python part of this! I remembered that we said that system Python 2 is fine, and we can work out what we do on Linux/future versions of macOS later down the line. I've backed the Python 3.8 dependency changes out and just done the syncing of the uses_from_macos lines from the Linux side.

@issyl0 issyl0 changed the title botan: Use Python 3.8, and sync `uses_from_macos` from Homebrew/linuxbrew-core botan: Sync `uses_from_macos` from Homebrew/linuxbrew-core Jan 8, 2020
@issyl0 issyl0 removed the python label Jan 8, 2020
@issyl0 issyl0 merged commit cd7485c into Homebrew:master Jan 8, 2020
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
@issyl0 issyl0 deleted the issyl0:botan-uses-from-macos branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.