Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chronograf 1.7.17 #48795

Closed
wants to merge 1 commit into from
Closed

Conversation

@chenrui333
Copy link
Member

chenrui333 commented Jan 9, 2020

Created with brew bump-formula-pr.

@chenrui333

This comment has been minimized.

Copy link
Member Author

chenrui333 commented Jan 9, 2020

20:58:44 go-bindata -o swagger_gen.go -ignore go -nocompress -pkg server .
20:58:44 server/swagger.go:3: running "go-bindata": exec: "go-bindata": executable file not found in $PATH
20:58:44 make: *** [server/swagger_gen.go] Error 1

@chenrui333 chenrui333 force-pushed the chenrui333:chronograf-1.7.17 branch from f38dfd0 to 060829d Jan 9, 2020
@issyl0 issyl0 added the test failure label Jan 11, 2020
@issyl0 issyl0 self-assigned this Jan 11, 2020
@issyl0

This comment has been minimized.

Copy link
Member

issyl0 commented Jan 11, 2020

Still the same kind of failure. It works locally:

$ brew test chronograf
Testing chronograf
INFO[0000] Running migration 59b0cda4fc7909ff84ee5c4f9cb4b655b6a26620
INFO[0000] Serving chronograf at http://[::]:8888        component=server
INFO[0000] Reporting usage stats                         component=usage freq=24h reporting_addr=https://usage.influxdata.com stats=os,arch,version,cluster_id,uptime   
==> curl -s 0.0.0.0:8888/chronograf/v1/
INFO[0000] Response: OK                                  component=server method=GET remote_addr=127.0.0.1:49942 response_time=225.86µs status=200
ERRO[0001] shutdown initiated
INFO[0001] Stopped serving chronograf at http://[::]:8888  component=server

How much sleeping is Jenkins allowed? 😄 I'm hesitant to up it any more, but at this point it's trial and error.

@issyl0

This comment has been minimized.

Copy link
Member

issyl0 commented Jan 11, 2020

Hmm, nomad has sleep 10 in its test, so I'm going to see if that works.

@issyl0

This comment has been minimized.

Copy link
Member

issyl0 commented Jan 11, 2020

Ten seconds did the trick. I'll squash all the commits together and then pull the bottles once CI is green again.

@issyl0 issyl0 force-pushed the chenrui333:chronograf-1.7.17 branch from b8f650f to 3455b64 Jan 11, 2020
- Fix the test for Jenkins by `sleep`ing for ten seconds rather than 3.

Co-authored-by: Rui Chen <chenrui333@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
@issyl0 issyl0 force-pushed the chenrui333:chronograf-1.7.17 branch from 3455b64 to 27a70f3 Jan 11, 2020
@chenrui333

This comment has been minimized.

Copy link
Member Author

chenrui333 commented Jan 11, 2020

🎉 Nice job!!

@alebcay alebcay closed this in 1c8c77b Jan 11, 2020
@issyl0

This comment has been minimized.

Copy link
Member

issyl0 commented Jan 11, 2020

@alebcay You beat me by a couple of seconds. 🥇 Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.