Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

now-cli: Fix test #48866

Merged
merged 1 commit into from Jan 10, 2020
Merged

now-cli: Fix test #48866

merged 1 commit into from Jan 10, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 10, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • The examples were moved, and the markdown example was somehow removed. (I can't find a reason why.)
  • Replace now init markdown with now init jekyll as that was the easiest thing I could think of that did exist, as it's still based on Markdown files and isn't an entire JS thing.

EDIT: Force-pushed as it helps if I git add my most recent local changes to get actual working tests. 馃槾

- The examples [were
  moved](zeit/now-examples@ec867ed)
  between the now archived, and the `markdown` example was somehow
  removed. (I can't find a reason why.)
- Replace `now init markdown` with `now init jekyll` as that was the
  easiest thing I could think of that did exist, as it's still based on
  Markdown files and isn't an entire JS thing.
@issyl0 issyl0 force-pushed the issyl0:now-cli-fix-test branch from 36e08d4 to 4d8648f Jan 10, 2020
@issyl0 issyl0 merged commit 3d46ebb into Homebrew:master Jan 10, 2020
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
@issyl0 issyl0 deleted the issyl0:now-cli-fix-test branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.