Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glow 0.2.0 (new formula) #48916

Closed
wants to merge 1 commit into from
Closed

glow 0.2.0 (new formula) #48916

wants to merge 1 commit into from

Conversation

@dawidd6
Copy link
Member

dawidd6 commented Jan 12, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

A CLI tool for rendering Markdown.

https://github.com/charmbracelet/glow

@dawidd6 dawidd6 force-pushed the dawidd6:glow branch from 21df4f5 to 1d40ff8 Jan 12, 2020
@issyl0

This comment has been minimized.

Copy link
Member

issyl0 commented Jan 12, 2020

The author already maintains a tap for this, so this source build PR might be of interest to them so that they can do less work. 😀

@dawidd6 dawidd6 force-pushed the dawidd6:glow branch from 1d40ff8 to d2ec127 Jan 12, 2020
@dawidd6

This comment has been minimized.

Copy link
Member Author

dawidd6 commented Jan 12, 2020

It's a goreleaser tap. Not really much work maintaining it, since it's updated automatically on release.

But yes. Would be wise to inform upstream author about this PR.

Formula/glow.rb Outdated Show resolved Hide resolved
@dawidd6 dawidd6 force-pushed the dawidd6:glow branch from d2ec127 to e82b173 Jan 12, 2020
@issyl0
issyl0 approved these changes Jan 12, 2020
Copy link
Member

issyl0 left a comment

Looks good, is notable enough, and passes all the CI checks. 💪 Thanks, @dawidd6!

@issyl0 issyl0 closed this in 0f79700 Jan 12, 2020
@dawidd6 dawidd6 deleted the dawidd6:glow branch Jan 12, 2020
@dawidd6 dawidd6 mentioned this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.