Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Revert addition of auto-labeller action for `bottle :unneeded` #48929

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 12, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

/opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/octokit-4.15.0/lib/octokit/response/raise_error.rb:16:in `on_complete': POST https://api.github.com/repos/Homebrew/homebrew-core/issues/48927/labels: 403 - Resource not accessible by integration // See: https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue (Octokit::Forbidden)
  • Given our PR workflow is "forked repo for everything", we can't do this until GitHub supports using secrets in forked PRs. It's a requested feature.
  • Maybe at some other point in the future, we can revisit this and other auto-labelling actions.
  • I enjoyed making it nonetheless, and now I have "forked repos" to add to my testing for future Actions proof-of-concepts!

Reverts #48911 and supersedes #48919.

馃槩

- I forgot that GitHub doesn't support [until there was a legitimate use case
  for adding a label](#48927),
  so the action will fail:

```
/opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/octokit-4.15.0/lib/octokit/response/raise_error.rb:16:in `on_complete': POST https://api.github.com/repos/Homebrew/homebrew-core/issues/48927/labels: 403 - Resource not accessible by integration // See: https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue (Octokit::Forbidden)
```

- Given our PR workflow is "forked repo for everything", we can't do this until
  GitHub supports using secrets in forked PRs. It's a [requested
  feature](https://github.community/t5/GitHub-Actions/how-to-use-GITHUB-TOKEN-for-PRs-from-forks/td-p/37450).
- Maybe at some other point in the future, we can revisit this and other
  auto-labelling actions.
- I enjoyed making it nonetheless, and now I have "forked repos" to add to my
  testing for future Actions proof-of-concepts!

----

Reverts #48911 and supersedes #48919.
Copy link
Member

chenrui333 left a comment

Sad to see it does not work for forked repos.

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 12, 2020

Jenkins won't tell us anything here, so I'm going to "as an administrator you may still merge this pull request".

@issyl0 issyl0 merged commit 232f4e1 into Homebrew:master Jan 12, 2020
1 check was pending
1 check was pending
continuous-integration/jenkins/ghprb Build triggered for merge commit.
Details
@issyl0 issyl0 deleted the issyl0:rm-auto-labeller-github-action branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.