Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-elasticache, aws-sns-cli, auto-scaling: delete #48936

Merged
merged 3 commits into from Jan 13, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 12, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I was doing some bump-formula-prs and noticed these old AWS formulae. Each of these formulae still build, but they have on average fewer than ten installs per month and their versions are super old (2012, 2014, etc). These tools' functionality has been rolled into the wider, more well-known AWS CLI according to the redirects of the homepages. In the spirit of only shipping maintained software, delete them.

I'm not entirely sure what our process for deleting things is - I'd like some (dis)approvals on this, please! But deleting these makes sense to me as these are particularly old ones which from the commit history have only had RuboCop fixes in the last ~5 years.

See commit messages for more information.

issyl0 added 3 commits Jan 12, 2020
- This has been folded into the main AWS CLI, based on the redirect that this
  formula's homepage does. I can't find any references to this individual CLI,
  only https://docs.aws.amazon.com/cli/latest/reference/elasticache/index.html
  as part of the main AWS CLI.
- This has had no new versions here since 2014, and 10 installs in the past 30
  days.
- This has been folded into the main AWS CLI, based on the redirect that this
  formula's homepage does. I can't find any references to this individual CLI,
  only https://docs.aws.amazon.com/cli/latest/reference/sns/index.html as part
  of the main AWS CLI.
- This has had no new versions here since 2013, and < 10 installs in the past 30
  days.
- This has been folded into the main AWS CLI, based on the redirect that this
  formula's homepage does. I can't find any references to this individual CLI,
  only https://docs.aws.amazon.com/cli/latest/reference/autoscaling/index.html
  as part of the main AWS CLI.
- This has had no new versions here since 2014, and < 10 installs in the past
  30 days.
Copy link
Member

fxcoudert left a comment

If they're not maintained / don't exist anymore, delete them!

@issyl0 issyl0 merged commit 1b44fa8 into Homebrew:master Jan 13, 2020
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
@issyl0 issyl0 deleted the issyl0:delete-old-aws-formulae branch Jan 13, 2020
@cmckni3

This comment has been minimized.

Copy link
Contributor

cmckni3 commented Jan 18, 2020

ha! #46688 🤷‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.