Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow-tools: uses_from_macos zlib #49919

Merged
merged 1 commit into from Feb 9, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 9, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • Over in Homebrew/linuxbrew-core we were seeing the following linkage error:
==> brew linkage --test flow-tools
Unwanted system libraries:
  /lib/x86_64-linux-gnu/libz.so.1
  ==> FAILED
- Over in Homebrew/linuxbrew-core we were seeing the following linkage error:

```
==> brew linkage --test flow-tools
Unwanted system libraries:
  /lib/x86_64-linux-gnu/libz.so.1
  ==> FAILED
```
@issyl0 issyl0 force-pushed the issyl0:flow-tools-uses-from-macos branch from c1c7e2d to a66ede6 Feb 9, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 9, 2020

The Mojave node failed:

11:06:50 Caused by: hudson.plugins.git.GitException: Command "git fetch --no-tags --force --progress -- https://github.com/Homebrew/homebrew-core/ +refs/heads/master:refs/remotes/origin/master +refs/pull/*:refs/remotes/origin/pr/*" returned status code 128:
11:06:50 stdout: 
11:06:50 stderr: fatal: remote error: upload-pack: not our ref ea369737732d46536fa225475aa51aa7981686d3e
11:06:50 fatal: the remote end hung up unexpectedly

I've rebased this branch on master, in case it was that, and let the checks re-run.

While these changes are all no-op on macOS and the CI failures were unrelated to my specific changes, I feel bad clicking the merge button when the build is red. And CI doesn't have much of a queue at the moment.

@issyl0 issyl0 merged commit e6c5f7c into Homebrew:master Feb 9, 2020
1 check passed
1 check passed
continuous-integration/jenkins/ghprb Build finished.
Details
@issyl0 issyl0 deleted the issyl0:flow-tools-uses-from-macos branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.