Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jack: Fix source tarball URL and depends_on/uses_from_macos ordering #49990

Closed
wants to merge 3 commits into from

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 10, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

- This was originally submitted as just the depends_on/uses_from_macos
  reordering in PR 49962, but the download URL had been moved in
  jackaudio/jackaudio.github.com@5fd24b2
@issyl0 issyl0 mentioned this pull request Feb 10, 2020
2 of 5 tasks complete
@bayandin

This comment has been minimized.

Copy link
Member

bayandin commented Feb 11, 2020

I hope you don't mind a little assistance @issyl0
Feel responsible for the suggestion "just to change the URL" 😄

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 11, 2020

Assistance is fine anytime!

@bayandin bayandin closed this in 77175ad Feb 18, 2020
@bayandin

This comment has been minimized.

Copy link
Member

bayandin commented Feb 18, 2020

Thanks @issyl0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.