Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navi 2.0.2 #51359

Closed
wants to merge 1 commit into from
Closed

navi 2.0.2 #51359

wants to merge 1 commit into from

Conversation

@denisidoro
Copy link
Contributor

denisidoro commented Mar 9, 2020

Why the change?

navi was initially implemented in bash but it has been rewritten in Rust (cf denisidoro/navi#201).

The formula needs to be rewritten as well because we now need to compile a binary, in opposition to interpreting a bunch of .sh files.

Previous attempt

This PR started as #51124 but I made some confusion when updating with master + squashing. I'm sorry.

@denisidoro denisidoro force-pushed the denisidoro:patch-3 branch 5 times, most recently from 845e357 to 76adb0e Mar 9, 2020
@denisidoro

This comment has been minimized.

Copy link
Contributor Author

denisidoro commented Mar 10, 2020

@Bo98, @chenrui333 and @SMillerDev, could you please review it? 👍

@SMillerDev

This comment has been minimized.

Copy link
Member

SMillerDev commented Mar 10, 2020

I'll get to it when I have time. Just like all other pull requests.

Formula/navi.rb Outdated Show resolved Hide resolved
Formula/navi.rb Outdated Show resolved Hide resolved
@denisidoro denisidoro changed the title navi 2.0.0 navi 2.0.2 Mar 10, 2020
@denisidoro denisidoro force-pushed the denisidoro:patch-3 branch from 369777c to bc4268b Mar 10, 2020
@denisidoro

This comment has been minimized.

Copy link
Contributor Author

denisidoro commented Mar 12, 2020

Closing without merging because this version isn't as stable as I would like. I'll open another PR in the future with a version I'm comfortable with (probably 2.1.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.