Skip to content

ki 0.3.3 (new formula) - #74409

Closed
SalvatoreT wants to merge 1 commit into
Homebrew:masterfrom
SalvatoreT:ki
Closed

ki 0.3.3 (new formula)#74409
SalvatoreT wants to merge 1 commit into
Homebrew:masterfrom
SalvatoreT:ki

Conversation

@SalvatoreT

@SalvatoreT SalvatoreT commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

Closes Kotlin/kotlin-interactive-shell#58

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added java Java use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Apr 2, 2021
SMillerDev
SMillerDev reviewed Apr 2, 2021
View reviewed changes
Comment thread Formula/ki.rb Outdated
@SalvatoreT
SalvatoreT force-pushed the ki branch 3 times, most recently from 15e250d to 6f82f2e Compare April 2, 2021 22:47
This was referenced Apr 2, 2021
Closed
Merged
Closed
@SalvatoreT
SalvatoreT force-pushed the ki branch 2 times, most recently from 117a200 to 8719b54 Compare April 9, 2021 04:57
@SalvatoreT SalvatoreT changed the title ki 0.3.1 (new formula) ki 0.3.3 (new formula) Apr 28, 2021
@SalvatoreT
SalvatoreT requested a review from SMillerDev April 28, 2021 16:33
@SalvatoreT SalvatoreT closed this Apr 28, 2021
@SalvatoreT SalvatoreT reopened this Apr 28, 2021
@SalvatoreT

SalvatoreT commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

We're back in business, babyyy! @SMillerDev, can you please give this a 馃憖 when you get the chance?

SMillerDev
SMillerDev reviewed Apr 28, 2021
View reviewed changes
Comment thread Formula/ki.rb Outdated
@SalvatoreT
SalvatoreT requested a review from SMillerDev April 28, 2021 21:43
@SalvatoreT
SalvatoreT requested a review from nandahkrishna May 2, 2021 20:10
nandahkrishna
nandahkrishna approved these changes May 2, 2021
View reviewed changes

@nandahkrishna nandahkrishna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SalvatoreT!

@SalvatoreT SalvatoreT mentioned this pull request May 2, 2021
Merged
@BrewTestBot

BrewTestBot commented May 3, 2021

Copy link
Copy Markdown
Contributor

:shipit: @SMillerDev has triggered a merge.

@SalvatoreT

SalvatoreT commented May 4, 2021

Copy link
Copy Markdown
Contributor Author

Thank you, @nandahkrishna and @SMillerDev!

@SalvatoreT
SalvatoreT deleted the ki branch May 4, 2021 16:03
@github-actions github-actions Bot added the outdated PR was locked due to age label Jun 4, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nandahkrishna nandahkrishna nandahkrishna approved these changes
@SMillerDev SMillerDev Awaiting requested review from SMillerDev
+1 more reviewer
@asm0dey asm0dey asm0dey left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

java Java use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offer a homebrew installation option

5 participants

@SalvatoreT @BrewTestBot @asm0dey @SMillerDev @nandahkrishna