Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiftool 12.25 #77174

Closed
wants to merge 1 commit into from
Closed

Conversation

edspiner
Copy link

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label May 13, 2021
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't marked as the production release yet: https://exiftool.org/history.html

@nandahkrishna nandahkrishna added the pre-release Artifact is pre-release label May 13, 2021
@carlocab
Copy link
Member

Thanks for the PR anyway, @edspiner. We only update exiftool to stable releases.

@carlocab carlocab closed this May 14, 2021
@edspiner
Copy link
Author

edspiner commented May 14, 2021

yeah I know (which is weird that ExifTool authors didn't mark new releases as stable) but version 12.24 introduced an important security fix to CVE-2021-22204. This is a dangerous security vulnerability as it allows code execution and exploit code is publicly available.

@mistydemeo
Copy link
Member

Reviewing the CVE report, this sounds serious. Let's skip our normal policy for this one version and switch back to stable versions when the next one comes out.

@mistydemeo mistydemeo reopened this May 18, 2021
@SMillerDev
Copy link
Member

Can we ask the exiftools authors to mark it stable in the meantime? We can't be the only ones who don't want to use unstable software.

@edspiner
Copy link
Author

Can we ask the exiftools authors to mark it stable in the meantime? We can't be the only ones who don't want to use unstable software.

OS vendors have distributed via security patches repositories as their own patches. Is there such an option within homebrew?

@carlocab
Copy link
Member

We can apply patches in the formula (grep for patch do for an example), but it seems simpler to just use the version that's already fixed.

@mistydemeo
Copy link
Member

Agreed, at this point I think using this release is the simplest way to ensure we're shipping a fix.

@carlocab
Copy link
Member

How are production releases for this tagged? Is that some future new release is cut, and then tagged as a production release, or is an older tag labelled as a production release after some time?

If it's the former, switching back to the stable release is easy (it just involves a version bump). If it's the latter, then that could possibly involve a version downgrade, which I'd like to avoid.

@mistydemeo
Copy link
Member

Is that some future new release is cut, and then tagged as a production release

It's this, which makes things quite convenient for us. We can simply switch over to a new production release when it comes out.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
@chenrui333 chenrui333 added superseded PR was replaced by another PR and removed pre-release Artifact is pre-release superseded PR was replaced by another PR labels Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants