New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lftp 4.7.5 (new formula) #9594

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@fxcoudert
Member

fxcoudert commented Feb 3, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This is a pull request to revive lftp, now that it builds again on macOS (almost unpatched). There was a pull request already, but its author has stopped updating it in response to reviews (#7371) so I am opening this one.

@nijikon nijikon added the new formula label Feb 3, 2017

depends_on "openssl"
depends_on "libidn"
# On Yosemite, the system's openssl gets chosen over ours, and it is too old

This comment has been minimized.

@woodruffw

woodruffw Feb 3, 2017

Member

This sounds like a build system bug that should probably be fixed upstream.

This comment has been minimized.

@fxcoudert

fxcoudert Feb 6, 2017

Member

I have opened an upstream issue: lavv17/lftp#317

This comment has been minimized.

@woodruffw

woodruffw Feb 7, 2017

Member

Thanks for reporting, and adding a note to the formula. I don't think it'll be a blocker here, but it'll be nice to remove that line eventually 😄

end
test do
system "#{bin}/lftp", "-c", "open ftp://mirrors.kernel.org; ls"

This comment has been minimized.

@woodruffw

woodruffw Feb 3, 2017

Member

I believe `mirrors.kernel.org's FTP service is being shut down later this year; it might be good to look for a replacement to test with.

This comment has been minimized.

@fxcoudert

fxcoudert Feb 6, 2017

Member

Replaced with GNU ftp

@woodruffw woodruffw referenced this pull request Feb 4, 2017

Closed

lftp 4.7.4 #7371

4 of 4 tasks complete
@woodruffw

This comment has been minimized.

Member

woodruffw commented Feb 7, 2017

This looks good to me. I'll leave it open a bit to give other maintainers a chance to review.

@MikeMcQuaid

This comment has been minimized.

Member

MikeMcQuaid commented Feb 10, 2017

Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@fxcoudert fxcoudert deleted the fxcoudert:lftp branch Feb 11, 2017

ilovezfs added a commit to Homebrew/homebrew-boneyard that referenced this pull request Feb 16, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.