-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libmarpa 8.6.2 (new formula) #97567
libmarpa 8.6.2 (new formula) #97567
Conversation
Formula/libmarpa.rb
Outdated
| class Libmarpa < Formula | ||
| desc "Marpa parse engine C library -- STABLE" | ||
| homepage "https://jeffreykegler.github.io/Marpa-web-site/libmarpa.html" | ||
| url "https://github.com/jeffreykegler/libmarpa/archive/refs/tags/v8.6.2.tar.gz", using: :nounzip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to use :nounzip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reproduce the build directory structure recommended by the library's HOWTO document
|
|
w.r.t. |
|
Bump. Have my responses to review comments been satisfactory? I'd like to know if there's anything else I need to do to get this formula accepted. Thanks! |
Thanks @cho-m! Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dabrahams ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?note: formula cookbook doesn't advise
--strictfor new formulas, but that finds more issues and appears to be required per above. Also it advises using--new-formulainstead of--new.