Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmarpa 8.6.2 (new formula) #97567

Closed
wants to merge 5 commits into from
Closed

Conversation

dabrahams
Copy link
Contributor

@dabrahams dabrahams commented Mar 22, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

note: formula cookbook doesn't advise --strict for new formulas, but that finds more issues and appears to be required per above. Also it advises using --new-formula instead of --new.

@BrewTestBot BrewTestBot added the new formula PR adds a new formula to Homebrew/homebrew-core label Mar 22, 2022
class Libmarpa < Formula
desc "Marpa parse engine C library -- STABLE"
homepage "https://jeffreykegler.github.io/Marpa-web-site/libmarpa.html"
url "https://github.com/jeffreykegler/libmarpa/archive/refs/tags/v8.6.2.tar.gz", using: :nounzip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to use :nounzip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reproduce the build directory structure recommended by the library's HOWTO document

Formula/libmarpa.rb Outdated Show resolved Hide resolved
@carlocab
Copy link
Member

Also it advises using --new-formula instead of --new.

--new-formula is synonymous with --new.

@dabrahams
Copy link
Contributor Author

w.r.t. --new-formula vs --new, they may be synonyms, but not everyone will know that, and having supposedly followed all the directions they've been given, will be frustrated that they're being asked by the PR template to run a different audit command.

@chenrui333 chenrui333 changed the title Add libmarpa libmarpa 8.6.2 (new formula) Mar 23, 2022
@dabrahams
Copy link
Contributor Author

Bump. Have my responses to review comments been satisfactory? I'd like to know if there's anything else I need to do to get this formula accepted.

Thanks!

dabrahams and others added 2 commits April 1, 2022 16:36
Thanks @cho-m!

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dabrahams ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants