Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's try ARGV => Homebrew.args again... #145

Merged
merged 3 commits into from Feb 3, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 3, 2020

See commits for (slightly) more detail. I can write more words tomorrow.

issyl0 added 2 commits Feb 3, 2020
This reverts commit 4b0d431 and applies
the later `brew build-bottle-pr` develop branch changes, fixing the
conflicts.
- The code that [looked for files starting with
  `brew-`](Homebrew/brew#6989) to detect
  internal vs. external arguments has been changed.
@request-info

This comment was marked as resolved.

Copy link

request-info bot commented Feb 3, 2020

Please provide a better issue/pull request title and/or description!

@issyl0 issyl0 removed the needs response label Feb 3, 2020
@issyl0 issyl0 self-assigned this Feb 3, 2020
@issyl0 issyl0 force-pushed the issyl0:revert-revert-homebrew-args branch from bad53b7 to 70d592b Feb 3, 2020
@issyl0 issyl0 marked this pull request as ready for review Feb 3, 2020
@issyl0 issyl0 merged commit 941d3fa into Homebrew:master Feb 3, 2020
1 check passed
1 check passed
test
Details
@issyl0 issyl0 deleted the issyl0:revert-revert-homebrew-args branch Feb 3, 2020
`build-bottle-pr` [`--remote=<user>`] [`--dry-run`] [`--verbose`] [`--tap-dir`] [`--force`]
Submit a pull request to build a bottle for a formula.
EOS
flag "--remote",

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member
Suggested change
flag "--remote",
flag "--remote=",

Append = if a value is required for the flag.

EOS
flag "--remote",
description: "Use the specified GitHub remote. Otherwise, use `origin`."
flag "--tap-dir",

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member
Suggested change
flag "--tap-dir",
flag "--tap-dir=",
description: "Open a web browser for the pull request."
switch "--dry-run",
description: "Do not actually raise any pull requests."
switch "--force",

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member
Suggested change
switch "--force",
switch :force,
description: "Use the specified full path to a tap. Otherwise, use the Homebrew on Linux standard install location."
switch "--browse",
description: "Open a web browser for the pull request."
switch "--dry-run",

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member
Suggested change
switch "--dry-run",
switch "-n", "--dry-run",
def build_bottle_pr_args
Homebrew::CLI::Parser.new do
usage_banner <<~EOS
`build-bottle-pr` [`--remote=<user>`] [`--dry-run`] [`--verbose`] [`--tap-dir`] [`--force`]

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member
Suggested change
`build-bottle-pr` [`--remote=<user>`] [`--dry-run`] [`--verbose`] [`--tap-dir`] [`--force`]
`build-bottle-pr` [`--remote=`<user>] [`--tap-dir=`<dir>] [`--browse`] [`--dry-run`] [`--force`] [`--verbose`]
`migrate-formula` [--remote=<remote>] [--tap=<tap>] <formulae>
Migrate formulae to a new tap.
EOS
flag "--remote",

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member
Suggested change
flag "--remote",
flag "--remote=",
EOS
flag "--remote",
description: "Use this GitHub remote, or $HOMEBREW_GITHUB_USER or $USER."
flag "--tap",

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member
Suggested change
flag "--tap",
flag "--tap=",
def squash_bottle_pr_args
Homebrew::CLI::Parser.new do
usage_banner <<~EOS
`squash-bottle-pr` [`--verbose`]

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member

Follow with line break.

def test_bot_docker_args
Homebrew::CLI::Parser.new do
usage_banner <<~EOS
`test-bot-docker` <formulae>

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member

Follow with line break.

def announce_args
Homebrew::CLI::Parser.new do
usage_banner <<~EOS
`announce` <formulae>

This comment has been minimized.

Copy link
@EricFromCanada

EricFromCanada Feb 3, 2020

Member

Follow with line break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.