Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request-bottle: die if user or email is empty #152

Merged
merged 1 commit into from Feb 5, 2020
Merged

Conversation

@dawidd6
Copy link
Member

dawidd6 commented Feb 5, 2020

Should prevent situations like this: Homebrew/linuxbrew-core@4840e61

@Homebrew Homebrew deleted a comment from request-info bot Feb 5, 2020
@dawidd6 dawidd6 removed the needs response label Feb 5, 2020
@issyl0
issyl0 approved these changes Feb 5, 2020
@dawidd6 dawidd6 merged commit bd1a0c5 into Homebrew:master Feb 5, 2020
1 check passed
1 check passed
test
Details
@dawidd6 dawidd6 deleted the dawidd6:refuse branch Feb 5, 2020
@jonchang

This comment has been minimized.

Copy link
Member

jonchang commented Feb 5, 2020

If all we're concerned about is attribution, I think we can do this purely from the GitHub API on the workflow end (meaning there's no need to include it with the dispatch payload) which can construct a no-reply email address and the rest of the details from the Users API and the dispatch sender details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.