Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request-bottle: On CI, use merge commit author for co-author #153

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 5, 2020

  • For auto-builds on GitHub Actions from merge commits, this used to set
    the co-authored-by line to the (Linux)BrewTestBot user.
  • We do however want some maintainer accountability for the actions of
    our bots, so set this to the author of the previous merge commit so
    there's a visible human involved.
- For auto-builds on GitHub Actions from merge commits, this used to set
  the co-authored-by line to the (Linux)BrewTestBot user.
- We do however want _some_ maintainer accountability for the actions of
  our bots, so set this to the author of the previous merge commit so
  there's a visible human involved.
@issyl0 issyl0 requested review from jonchang and iMichka Feb 5, 2020
cmd/request-bottle.rb Outdated Show resolved Hide resolved
Copy link
Member

jonchang left a comment

Just a style nit. I think the early return for the special case merge commit would be easier to follow, followed by the regular case from non-CI.

cmd/request-bottle.rb Outdated Show resolved Hide resolved
cmd/request-bottle.rb Outdated Show resolved Hide resolved
dawidd6 added 2 commits Feb 6, 2020
@dawidd6

This comment has been minimized.

Copy link
Member

dawidd6 commented Feb 6, 2020

Let's try it.

@dawidd6 dawidd6 merged commit 3db473d into Homebrew:master Feb 6, 2020
1 check passed
1 check passed
test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.