Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekg2 livecheck issue #408

Closed
chenrui333 opened this issue Mar 10, 2020 · 3 comments
Closed

ekg2 livecheck issue #408

chenrui333 opened this issue Mar 10, 2020 · 3 comments
Assignees
Labels
bug

Comments

@chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Mar 10, 2020

$ brew livecheck ekg2
ekg2 (guessed) : 0.3.1 ==> 2_0.3.1
brew livecheck ekg2 --debug
Trying with url https://src.fedoraproject.org/lookaside/extras/ekg2/ekg2-0.3.1.tar.gz/68fc05b432c34622df6561eaabef5a40/ekg2-0.3.1.tar.gz
Trying with url https://web.archive.org/web/20161227025528/pl.ekg2.org/ekg2-0.3.1.tar.gz
Trying with url https://github.com/ekg2/ekg2
Possible git repo detected at https://github.com/ekg2/ekg2.git
ekg2_0-1-0 => #<Version:0x00007fe3d40faec8 @version="2_0-1-0", @tokens=[#<Version::NumericToken 2>, #<Version::NumericToken 0>, #<Version::NumericToken 1>, #<Version::NumericToken 0>]>
ekg2_0-1-1 => #<Version:0x00007fe3d40fadd8 @version="2_0-1-1", @tokens=[#<Version::NumericToken 2>, #<Version::NumericToken 0>, #<Version::NumericToken 1>, #<Version::NumericToken 1>]>
ekg2_0-1_branch_root => #<Version:0x00007fe3d40fad10 @version="2_0-1_branch_root", @tokens=[#<Version::NumericToken 2>, #<Version::NumericToken 0>, #<Version::NumericToken 1>, #<Version::StringToken "branch">, #<Version::StringToken "root">]>
ekg2_0-2_branch_root => #<Version:0x00007fe3d40fac48 @version="2_0-2_branch_root", @tokens=[#<Version::NumericToken 2>, #<Version::NumericToken 0>, #<Version::NumericToken 2>, #<Version::StringToken "branch">, #<Version::StringToken "root">]>
ekg2_0.3.0 => #<Version:0x00007fe3d40fab30 @version="2_0.3.0", @tokens=[#<Version::NumericToken 2>, #<Version::NumericToken 0>, #<Version::NumericToken 3>, #<Version::NumericToken 0>]>
ekg2_0.3.1 => #<Version:0x00007fe3d40fa540 @version="2_0.3.1", @tokens=[#<Version::NumericToken 2>, #<Version::NumericToken 0>, #<Version::NumericToken 3>, #<Version::NumericToken 1>]>
ekg2 (guessed) : 0.3.1 ==> 2_0.3.1
@samford

This comment has been minimized.

Copy link
Member

@samford samford commented Mar 10, 2020

For anyone reading this, you get the output above with a livecheckable like this (which doesn't exist yet):

class Ekg2
  livecheck :url   => "https://github.com/ekg2/ekg2.git",
            :regex => /^ekg2_(\d+(?:\.\d+)+)$/
end

This issue occurs when using the Git strategy and the tags start with a name ending in a digit (e.g., ekg2_0.3.1). I have an idea of how to fix this, so I'll work on it when I get a chance.

@samford samford self-assigned this Mar 10, 2020
@chenrui333

This comment has been minimized.

Copy link
Member Author

@chenrui333 chenrui333 commented Mar 10, 2020

Sounds good!

samford added a commit to samford/homebrew-livecheck that referenced this issue Mar 12, 2020
Fixes Homebrew#408.
samford added a commit to samford/homebrew-livecheck that referenced this issue Mar 12, 2020
Closes Homebrew#408.
samford added a commit to samford/homebrew-livecheck that referenced this issue Mar 12, 2020
Fixes Homebrew#408.
samford added a commit to samford/homebrew-livecheck that referenced this issue Mar 12, 2020
Fixes Homebrew#408.
samford added a commit to samford/homebrew-livecheck that referenced this issue Mar 12, 2020
Fixes Homebrew#408.
samford added a commit to samford/homebrew-livecheck that referenced this issue Mar 12, 2020
Fixes Homebrew#408.
@samford

This comment has been minimized.

Copy link
Member

@samford samford commented Mar 12, 2020

I created a PR (#444) that addresses the underlying issue here when getting versions from Git tags. Once #444 is merged, #443 will add a livecheckable for ekg2 and it should work as expected.

@samford samford added the bug label Mar 12, 2020
samford added a commit to samford/homebrew-livecheck that referenced this issue Mar 15, 2020
Fixes Homebrew#408.
@samford samford closed this in #444 Mar 15, 2020
samford added a commit that referenced this issue Mar 15, 2020
Fixes #408.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.