This repository has been archived by the owner. It is now read-only.

Updated PHP 7.1 from RC6 to stable 7.1.0 #3795

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@devjack
Copy link
Contributor

devjack commented Dec 2, 2016

  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

This patch updates the PHP 7.1 formula to 7.1.0 (replacing the previous 7.1RC6).

Updated formulae for PHP71 stable release.
Local installs run smoothly (excl. missing bottles prompting source install).

$ brew tap homebrew/homebrew-php <fork url>
$ brew install php71
$ php --version
PHP 7.1.0 (cli) (built: Dec  2 2016 15:36:22) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.1.0-dev, Copyright (c) 1998-2016 Zend Technologies
@alcaeus

This comment has been minimized.

Copy link
Contributor

alcaeus commented Dec 2, 2016

IIRC you also need to increase the revision number in the php71.rb formula to trigger a rebuild of the bottles.

@javian

This comment has been minimized.

Copy link
Member

javian commented Dec 2, 2016

Yes that's correct. Can you make the update @devjack ?

@devjack

This comment has been minimized.

Copy link
Contributor Author

devjack commented Dec 2, 2016

Thanks @alcaeus, thats the step I missed.
@javian Updated the revision in 86258ab.
Cheers!

@freekmurze

This comment has been minimized.

Copy link

freekmurze commented Dec 2, 2016

Thanks for all the work you put into this. Can't wait to upgrade my dev environment. Any ETA when this will be pulled in?

@bbashy

This comment has been minimized.

Copy link

bbashy commented Dec 2, 2016

Eager to have this too! 👍

Thanks.

@devjack

This comment has been minimized.

Copy link
Contributor Author

devjack commented Dec 3, 2016

I'm having some trouble understanding whats missing to cleanup the .h files after build (causing audit to fail). Happy to do the work to get this merged if anyone can offer some pointers?

@javian

This comment has been minimized.

Copy link
Member

javian commented Dec 3, 2016

@devjack We've been leaving it like that for now just accepting that it breaks the CI bot. We could remove the include but I don't know if someone is currently depending on it but potentially we could make i optional (like using --with-headers) so it doesn't break the CI.

@javian javian closed this in e513996 Dec 3, 2016

@javian

This comment has been minimized.

Copy link
Member

javian commented Dec 3, 2016

Thanks for the submission @devjack !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.