This repository has been archived by the owner. It is now read-only.

php71-msgpack: add 2.0.2-stable bottle. #3822

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@rela1470
Contributor

rela1470 commented Dec 8, 2016

  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

add msgpack-2.0.2-stable for PHP7.1
https://pecl.php.net/package/msgpack/2.0.2

@javian

This comment has been minimized.

Show comment
Hide comment
@javian

javian Dec 8, 2016

Contributor

Please do not name the commits is this way - please stick to " " if its an update. Otherwise we have to edit the commit message when merging which takes additional time. Can you update it please ?

Contributor

javian commented Dec 8, 2016

Please do not name the commits is this way - please stick to " " if its an update. Otherwise we have to edit the commit message when merging which takes additional time. Can you update it please ?

@javian

This comment has been minimized.

Show comment
Hide comment
@javian

javian Dec 8, 2016

Contributor

And if its a new formula then do <formulaname> <version> (new formula)

Contributor

javian commented Dec 8, 2016

And if its a new formula then do <formulaname> <version> (new formula)

@rela1470

This comment has been minimized.

Show comment
Hide comment
@rela1470

rela1470 Dec 8, 2016

Contributor

@javian I changed commit message!

Contributor

rela1470 commented Dec 8, 2016

@javian I changed commit message!

@alcaeus

This comment has been minimized.

Show comment
Hide comment
@alcaeus

alcaeus Dec 8, 2016

Contributor

@rela1470 while you're at it, could you update php70-msgpack to 2.0.2 as well?

Contributor

alcaeus commented Dec 8, 2016

@rela1470 while you're at it, could you update php70-msgpack to 2.0.2 as well?

@javian javian closed this in a63b989 Dec 8, 2016

@javian

This comment has been minimized.

Show comment
Hide comment
@javian

javian Dec 8, 2016

Contributor

Thanks @rela1470 ! As @alcaeus pointed out - would you mind also submitting an update to the 7.0 formula ?

Contributor

javian commented Dec 8, 2016

Thanks @rela1470 ! As @alcaeus pointed out - would you mind also submitting an update to the 7.0 formula ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.