This repository has been archived by the owner. It is now read-only.

php71: migrate to homebrew/core #4798

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
8 participants
@kabel
Copy link
Contributor

kabel commented Mar 3, 2018

  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?

Depends on Homebrew/homebrew-core#24766

@javian

This comment has been minimized.

Copy link
Member

javian commented Mar 12, 2018

@BrewTestBot test this please

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Mar 12, 2018

@kabel it seems there are a couple of formulae with hardcoded php71 dependencies. Would you mind checking these?

Error: Invalid formula: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-php/Formula/infection.rb
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-php/Formula/xdebug-osx.rb
No available formula with the name "php71"
No available formula with the name "php71"

@kabel

This comment has been minimized.

Copy link
Contributor

kabel commented Mar 12, 2018

Will do. Had it locally but didn't commit/push

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Mar 28, 2018

@BrewTestBot test this please

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Mar 28, 2018

@kabel can you rebase once more?

@MikeMcQuaid MikeMcQuaid force-pushed the kabel:php71tocore branch from e987435 to 1c094c2 Mar 28, 2018

@ilovezfs ilovezfs force-pushed the kabel:php71tocore branch from 1c094c2 to 8a87add Mar 28, 2018

@ilovezfs ilovezfs force-pushed the kabel:php71tocore branch from 8a87add to efa9bf4 Mar 29, 2018

@ilovezfs ilovezfs merged commit ab5fffa into Homebrew:master Mar 29, 2018

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Mar 29, 2018

Thanks @kabel!

@Saeven

This comment has been minimized.

Copy link

Saeven commented Mar 30, 2018

Question - how do we install --with-postgresql, or install

php71-intl
php71-pspell
php71-pdo-pgsql
php71-mcrypt

as was done before the change?

Thank you!

@kabel kabel deleted the kabel:php71tocore branch Mar 30, 2018

@kabel

This comment has been minimized.

Copy link
Contributor

kabel commented Mar 30, 2018

After you brew install php@7.1 those extensions are already included. See $(brew --prefix)/opt/php@7.1/bin/php -m. No need to use any install options or separate formulae.

@Saeven

This comment has been minimized.

Copy link

Saeven commented Mar 30, 2018

Damn you beat me to it. Thanks @kabel, just ran php -i and saw them.

@orcinus

This comment has been minimized.

Copy link

orcinus commented Mar 31, 2018

I'm sorry, but this is a complete and utter mess compared to the "old" josegonzales kegs.
Doesn't automatically import into path, no way to pick extensions, and to top it all off, getting this:

PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/local/opt/php71-intl/intl.so' - dlopen(/usr/local/opt/php71-intl/intl.so, 9): image not found in Unknown on line 0

Warning: PHP Startup: Unable to load dynamic library '/usr/local/opt/php71-intl/intl.so' - dlopen(/usr/local/opt/php71-intl/intl.so, 9): image not found in Unknown on line 0

Which sounds oddly familiar from here:
#4384

Tried brew reinstall, no dice.

@kabel

This comment has been minimized.

Copy link
Contributor

kabel commented Mar 31, 2018

@orcinus Migrations tend to be a bit messy. The warning you are receiving are from old configuration files that no longer apply to the migrated formula. Please check your /usr/local/etc/php/7.1/conf.d/ for extension ini files that aren't automatically removed.

The automatic linking (importing into path) is a feature reserved for the most recent php branch. If you wish to use this version exclusively, you can force the linking with brew link --force php@7.1.

@simPod

This comment has been minimized.

Copy link

simPod commented Mar 31, 2018

Where did SNMP extension go?

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Mar 31, 2018

@simPod SNMP was excluded from the build because it crashes Apache.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Mar 31, 2018

I'm sorry, but this is a complete and utter mess compared to the "old" josegonzales kegs.

@orcinus Read our Code of Conduct and adjust your future communication accordingly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.