Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Convert to using launchctl bootstrap instead of deprecated launchctl load -w #112
As discussed in #111, convert to using
This gives us error reporting, which fixes #111. It also means we're not using a deprecated API, which is good. And it also paves the way for better separation of root vs. user (e.g. so the same command need not do different things in those cases), and perhaps also to fix the problems of running launchctl under tmux/screen (maybe).
While we're here, document the
Example of error detection we didn't have before:
Also, with a deliberately malformed plist, we used to fail undetectably:
and now we do it right:
Note, this was also discussed, somewhat datedly, at Homebrew/legacy-homebrew#33259.
Did I misunderstand @MikeMcQuaid:
It's easy enough to conditionalize this on
That would be good. I thought the changes would be more involved so it should be relatively straightforward to keep the old code around, thanks (and sorry to change my mind).
Wha-huh? That seems so unlike---oh, how convenient. Final commit was cd4fc93 which changed only whitespace (removed a blank line). Prior commit also had a Travis run that succeeded. I think this means there's some nondeterminance in the
I suppose the other possibility is there is nondeterminancy in the code in this PR, but that does not seem likely to me, since I didn't ever have it fail through repeated testing and whacking on my local system.
Thoughts? "It's never the test…except when it is."