Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Travis and Circle CI. #312

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 9, 2020

These are no longer used by any official Homebrew taps so nudge people towards GitHub Actions or Azure Pipelines instead.

These are no longer used by any official Homebrew taps so nudge people
towards GitHub Actions or Azure Pipelines instead.
@issyl0
issyl0 approved these changes Jan 9, 2020
Copy link
Member

issyl0 left a comment

Though you'll need to remove the required status check for Travis on this repo, too.

@maxim-belkin

This comment has been minimized.

Copy link
Member

maxim-belkin commented Jan 9, 2020

May I suggest to factor out all CIs into their own files which are sourced when / if necessary? The fact that Homebrew no longer uses CircleCI / Travis is fine but it feels strange that one has to manually look for pieces that correspond to a particular CI.

@MikeMcQuaid MikeMcQuaid merged commit d97577d into Homebrew:master Jan 9, 2020
3 checks passed
3 checks passed
tests (ubuntu-latest)
Details
tests (macOS-latest)
Details
homebrew-test-bot Build #20200109.1 succeeded
Details
@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:remove-circle-travis branch Jan 9, 2020
@MikeMcQuaid

This comment has been minimized.

Copy link
Member Author

MikeMcQuaid commented Jan 9, 2020

May I suggest to factor out all CIs into their own files which are sourced when / if necessary?

I'm open to further refactoring of brew test-bot but don't plan on doing so in the near future myself. Also, given Jenkins support will 💀 hopefully in 2020 and GitHub Actions and Azure Pipelines perform nearly identically the divergence should be minimal.

@sjackman

This comment has been minimized.

Copy link
Member

sjackman commented Jan 9, 2020

RIP

issyl0 added a commit to issyl0/homebrew-linux-dev that referenced this pull request Jan 19, 2020
- None of the core Linux taps (Homebrew/linuxbrew-core, Homebrew/homebrew-xorg) use Circle CI any more. And it's [unsupported in `brew test-bot`](Homebrew/homebrew-test-bot#312).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.