Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Azure Pipelines as a supported CI provider #325

Merged
merged 2 commits into from Feb 13, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 4, 2020

  • Homebrew/linuxbrew-core was the only user of Azure Pipelines, but
    we've switched to GitHub Actions.
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 4, 2020

Oh, of course, the CI checks still try to run for Azure.

EDIT: I removed the pipeline YAML and disabled the required Azure status check in the branch protection settings.

- Homebrew/linuxbrew-core was the only user of Azure Pipelines, but
  we've switched to GitHub Actions.
@issyl0 issyl0 force-pushed the issyl0:rm-azure branch from 9d83435 to 54ad9a4 Feb 4, 2020
@ladislas

This comment has been minimized.

Copy link
Contributor

ladislas commented Feb 4, 2020

why remove it? people (including @osx-cross) are using it for their tap process.

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 4, 2020

I was basing this on the fact we removed Travis and Circle when they weren't used in any official taps. @MikeMcQuaid What do you think here?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Feb 12, 2020

@ladislas asked by private email if he could have time to migrate his tap. Have you done that yet @ladislas? Thanks!

cmd/test-bot.rb Outdated Show resolved Hide resolved
cmd/test-bot.rb Outdated Show resolved Hide resolved
cmd/test-bot.rb Outdated Show resolved Hide resolved
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
@ladislas

This comment has been minimized.

Copy link
Contributor

ladislas commented Feb 13, 2020

Yes you can merge.

@MikeMcQuaid MikeMcQuaid merged commit 9ba3b5d into Homebrew:master Feb 13, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest)
Details
tests (macOS-latest)
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Feb 13, 2020

Thanks for this @issyl0 🎉 ❤️

@sashkab

This comment has been minimized.

Copy link

sashkab commented Feb 13, 2020

So tap-new still creates azure-pipelines.yml, while Azure Pipelines no longer supported. Is this intended?

https://github.com/Homebrew/brew/blob/d556d02cd48de62f7f621488405bef5ac74f6998/Library/Homebrew/dev-cmd/tap-new.rb#L52

issyl0 added a commit to issyl0/brew that referenced this pull request Feb 15, 2020
- We recently removed Azure as a supported CI provider
  (Homebrew/homebrew-test-bot#325), so `brew
  test-bot` won't run on Azure any more.
@issyl0 issyl0 deleted the issyl0:rm-azure branch Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.