-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formulae: set root_url to GitHub Releases url #486
Conversation
Not entirely sure on the |
ec83dcd
to
7cb8a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me (minus @Bo98's question I'd like to see figured out). --ci-upload
should probably be configured to fail with a helpful message given this case, too?
Yes, Also added a check for |
c31ecec
to
2af514b
Compare
2af514b
to
3f4c10b
Compare
3f4c10b
to
0d4f2a4
Compare
0d4f2a4
to
4a2debf
Compare
If not testing core tap (and a bunch of other conditions), set the root_url to GitHub releases url.
This url would later be used in
brew pr-upload
to determine what release to create.