Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

gettext: always use bundled libraries

We have been explicitly passing "--without-included-glib", etc. to the
but this doesn't make sense: the flag does not mean "don't use glib at
all", it means "don't use the bundled glib", which means "use an
external copy of glib if one exists, but otherwise fall back to the
included version anyway".

This can lead to subtle breakage: if a user has installed glib, and then
gettext is built from source, gettext will link to the external glib.
When the user goes to upgrade glib the next time around, the build will
fail when it tries to use the now broken gettext binaries.

So in most cases, our gettext formula has been using these bundled
libraries anyway. The most obvious case is the bottles, which do not
have external linkage to glib, libunistring, etc.

In order to cover all cases, _always_ build with the included libraries.

There is no need to rebuild the bottles for these changes, as they are
correct already.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
  • Loading branch information...
commit 27163b399471f613aaacb2d39b1d20468530671e 1 parent 9d905be
@jacknagel jacknagel authored
Showing with 6 additions and 5 deletions.
  1. +6 −5 Library/Formula/gettext.rb
View
11 Library/Formula/gettext.rb
@@ -34,12 +34,13 @@ def install
ENV.libxml2
ENV.universal_binary if build.universal?
- system "./configure", "--disable-dependency-tracking", "--disable-debug",
+ system "./configure", "--disable-dependency-tracking",
+ "--disable-debug",
"--prefix=#{prefix}",
- "--without-included-gettext",
- "--without-included-glib",
- "--without-included-libcroco",
- "--without-included-libxml",
+ "--with-included-gettext",
+ "--with-included-glib",
+ "--with-included-libcroco",
+ "--with-included-libunistring",
"--without-emacs",
# Don't use VCS systems to create these archives
"--without-git",
Please sign in to comment.
Something went wrong with that request. Please try again.