Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

scantailor doesn't build with clang #11817

Closed
dsanson opened this Issue · 5 comments

4 participants

@dsanson

Per the discussion here, scantailor does not currently build with clang. It builds fine with gcc, though, so brew install scantailor --gcc worked fine.

From the discussion referenced, it appears that it may be awhile before this gets resolved. Should the formula be changed to use gcc by default?

@jacknagel jacknagel closed this issue from a commit
@jacknagel jacknagel scantailor: fails with clang
Fixes #11817.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
7f8dcab
@jacknagel jacknagel closed this in 7f8dcab
@jacknagel
Owner

Marked as fails_with :clang in 7f8dcab

@mistydemeo
Owner

re: gcc, we can't make it build with gcc by default since gcc no longer ships with current versions of Xcode. Jack marked it fails_with :clang which will cause scantailor to fall back to something appropriate based on what you have installed - that will be llvm-gcc for Xcode 4.2+, which builds scantailor great.

@erikg erikg referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@rohansingh rohansingh referenced this issue from a commit in rohansingh/homebrew
@jacknagel jacknagel scantailor: fails with clang
Fixes #11817.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
38ae762
@Sharpie Sharpie referenced this issue from a commit in Sharpie/homebrew
@jacknagel jacknagel scantailor: fails with clang
Fixes #11817.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
64b4090
@snakeyroc3 snakeyroc3 referenced this issue from a commit in snakeyroc3/homebrew
@jacknagel jacknagel scantailor: fails with clang
Fixes #11817.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
4f228a1
@muellermartin

I made it run with Clang by creating a patch which I uploaded to https://gist.github.com/muellermartin/8569243

Unfortunately I can't find any precise information on how to submit an edited formula to Homebrew, becuase I never did it before… Maybe someone could help or do it for me?

@mistydemeo
Owner

Thanks! Can you submit your patch to the scan tailor developers?

Instructions on how to submit are here: https://github.com/Homebrew/homebrew/wiki/Formula-Cookbook#commit If you want help, I'm usually in our IRC channel, #machomebrew on the Freenode network. Pop in and I'd be glad to help out.

@muellermartin

I've submitted the patch to their mailing list and hopefully they'll include it, because the project seems to be pretty quiet for a while…

I'll come by the IRC channel and ask for assistance with the homebrew patch submission ;)

@muellermartin muellermartin referenced this issue from a commit in muellermartin/homebrew
@muellermartin muellermartin Fixes #11817: Scan Tailor now builds with Clang 94e699f
@BrewTestBot BrewTestBot referenced this issue from a commit in BrewTestBot/homebrew
@muellermartin muellermartin Fixes #11817: Scan Tailor now builds with Clang f755e0a
@muellermartin muellermartin referenced this issue from a commit in muellermartin/homebrew
@muellermartin muellermartin Fixes #11817: Scan Tailor now builds with Clang e6e9c32
@muellermartin muellermartin referenced this issue from a commit in muellermartin/homebrew
@muellermartin muellermartin Fixes #11817: Scan Tailor now builds with Clang b859abf
@muellermartin muellermartin referenced this issue from a commit in muellermartin/homebrew
@muellermartin muellermartin Fixes #11817: Scan Tailor now builds with Clang c6a0704
@mistydemeo mistydemeo referenced this issue from a commit
@muellermartin muellermartin scantailor: upstream patch to build with clang
Fixes #11817.
Closes #27919.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2e40afe
@ehershey ehershey referenced this issue from a commit in ehershey/homebrew
@muellermartin muellermartin scantailor: upstream patch to build with clang
Fixes #11817.
Closes #27919.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
8b0b98f
@yeled yeled referenced this issue from a commit in yeled/homebrew
@muellermartin muellermartin scantailor: upstream patch to build with clang
Fixes #11817.
Closes #27919.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
426e40b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.