Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

depends_on :stdenv #14654

Closed
2bits opened this Issue · 13 comments

6 participants

@2bits

We probably could use depends_on :stdenv
You can imagine why I suppose.

@adamv
Owner

This.

@mxcl
Collaborator

Yes, I intended something like this, but am not the DSL king in Formula. I am scared of that class in general.

Though it is not a solution to superenv bugs, the solution to those is for me to fix them. There are only a few formula that will probably need this.

Also, finally, is this really a depends_on thing? Let's not force everything in there. stdenv is not something you can install, like x11 or the CLT. It is a homebrew environment feature, a different DSL. Like:

env :std
@2bits

That makes more sense, ENV.std. Some of the apps (from memory):

  • graphviz
  • guile
  • solfege
  • pango
@samueljohn

I am currently working on python to make it work with superenv. Right now I still get building dbm using ndbm
error: /usr/include/zlib.h: No such file or directory
. I still have to get superenv into my head.

@mxcl
Collaborator
  • pango is fixed.
  • The Solfege is not a superenv bug, it's an X11 dependency bug.
  • Graphviz is already excluded (build.rb has a blacklist).
  • guile is fixed (brew update, recent change fixed it, essentially it was a regression)

I am currently working on python to make it work with superenv. Right now I still get building dbm using ndbm
error: /usr/include/zlib.h: No such file or directory. I still have to get superenv into my head.

Sounds like a NCLT issue and not a superenv issue to me. Something is requesting an explicit path to /usr/include/zlib.h.

superenv (should) be easy to understand: Nothing is set, any issues you then have can be fixed by setting stuff (eg. CPPFLAGS). If it seems hard to understand then I've not explained it well enough, but essentially it shouldn't require any difficult thinking. The problems so far have been bugs.

@samueljohn

@mxcl I got it :-) Was confused because python was blacklisted and actually uses the old std env. The problem was not superenv but python only looking through -I flags to find zlib.h on NCLT systems. There is a PR #14689 for this now.

I am no longer trying to make python superenv compatible, because I'd need to essentially recreate the vars as they are in --env=std, so I think it's best to stick with that.

@mxcl
Collaborator

I plan to improve stdenv with some lessons learned making superenv, so the current issues with python attributed to stdenv should be fixable.

Stdenv will always exist as it is flexible, where superenv is not. Instead superenv is reliable (with a little more work).

@mistydemeo
Owner

Related: --32-bit should always imply stdenv. (At the moment builds which request a 32-bit build are broken unless the user also passes --env=std, which is counter-intuitive.)

@mxcl
Collaborator

superenv can support this, just as a general design goal it was not flexible, with the end that options would be added as they were discovered to still be necessary.

@mxcl
Collaborator

Great. Merge.

Though I don't think we need env :x11 anymore, and maybe that's even a bad idea. You should only be able to add the X11 env by depending on it.

@adamv
Owner

Ok, will clean this up and then merge. Hopefully won't cause jack too much merge pain.

@jacknagel
Owner

Go for it, I don't think my work touches much code in this area.

@adamv adamv closed this issue from a commit
@adamv adamv Support env :std, :userpaths
Closes #14654.
c6f30a7
@adamv adamv closed this in c6f30a7
@halloleo halloleo referenced this issue from a commit
@adamv adamv Support env :std, :userpaths
Closes #14654.
6bb2467
@Sharpie Sharpie referenced this issue from a commit in Sharpie/homebrew
@adamv adamv Support env :std, :userpaths
Closes #14654.
73d0de3
@DennisOSRM DennisOSRM referenced this issue from a commit
@adamv adamv Support env :std, :userpaths
Closes #14654.
a78db1b
@snakeyroc3 snakeyroc3 referenced this issue from a commit in snakeyroc3/homebrew
@adamv adamv Support env :std, :userpaths
Closes #14654.
7e020e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.